From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id F41C7EBE
	for <devicetree@vger.kernel.org>; Tue, 19 Sep 2023 06:14:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AD96C433C7;
	Tue, 19 Sep 2023 06:14:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1695104091;
	bh=Lgd5+nYbpB9ZFLzoFtX/eam0a0z2Dw22oPiFpAlfiZg=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=iQyPYAebob2b+Cm8kfLBd/WNROy8/CTQdrrPZcpGUuC0F0RZAoAIFSFaCpMAX40eD
	 /NeEvOs7WdWkYLs1xctmfSbmzhkCGEFTrXT6ZmF7RJ62hIkxKP1UeZbjsHSBjA7gYg
	 FhGWi+kcW/WqfBaSrs2REN9MeyPl9FD+rYManlTOYwym3Z5Qp09r0dUkaVWoYCTCMv
	 LUNf7XpsrE2uC36YMhw3TS2F5QDRFSoSMgtFH4Qkxcb2He/KRLyWftZE/VOjqdqkWw
	 Oh+j9hjn4qDk0yVg4KX4d4oqgF4Cw1drlDulE0Mp9j5erTT9FATYCq9ESd4niPwhRh
	 8V9lEbMZ1exgg==
Received: from johan by xi.lan with local (Exim 4.96)
	(envelope-from <johan@kernel.org>)
	id 1qiU0m-0006Eq-1E;
	Tue, 19 Sep 2023 08:15:04 +0200
Date: Tue, 19 Sep 2023 08:15:04 +0200
From: Johan Hovold <johan@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>, agross@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.5 30/36] arm64: dts: qcom: sc8280xp-x13s: Add
 camera activity LED
Message-ID: <ZQk8aJx268Soy4yH@hovoldconsulting.com>
References: <20230908192848.3462476-1-sashal@kernel.org>
 <20230908192848.3462476-30-sashal@kernel.org>
 <ZP60ngCV3hhNZiX5@hovoldconsulting.com>
 <ZQjEEt7sB2M5EO53@sashalap>
Precedence: bulk
X-Mailing-List: devicetree@vger.kernel.org
List-Id: <devicetree.vger.kernel.org>
List-Subscribe: <mailto:devicetree+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:devicetree+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZQjEEt7sB2M5EO53@sashalap>

On Mon, Sep 18, 2023 at 05:41:38PM -0400, Sasha Levin wrote:
> On Mon, Sep 11, 2023 at 08:33:02AM +0200, Johan Hovold wrote:
> >On Fri, Sep 08, 2023 at 03:28:41PM -0400, Sasha Levin wrote:
> >> From: Konrad Dybcio <konrad.dybcio@linaro.org>
> >>
> >> [ Upstream commit 1c63dd1c5fdafa8854526d7d60d2b741c813678d ]
> >>
> >> Disappointigly, the camera activity LED is implemented in software.
> >> Hook it up as a gpio-led and (until we have camera *and* a "camera on"
> >> LED trigger) configure it as a panic indicator.
> >>
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >> Link: https://lore.kernel.org/r/20230805-topic-x13s_cam_led-v1-1-443d752158c4@linaro.org
> >> Signed-off-by: Bjorn Andersson <andersson@kernel.org>
> >> Signed-off-by: Sasha Levin <sashal@kernel.org>
> >
> >This is a new feature if anything, not a fix. Please drop from all
> >autosel queues.
> 
> Not a feature, but hardware enablement.

Call it what you will, but please drop it. Otherwise by that logic you'd
need to backport all devicetree patches (as well as most driver changes)
since they ultimately aim at enabling hardware.

Johan