From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C483B18C38 for ; Thu, 21 Sep 2023 21:51:14 +0000 (UTC) Received: from out-221.mta0.migadu.com (out-221.mta0.migadu.com [IPv6:2001:41d0:1004:224b::dd]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84DCAA252 for ; Thu, 21 Sep 2023 14:51:12 -0700 (PDT) Date: Fri, 22 Sep 2023 07:35:19 +1000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1695333070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QqdCzsBT+posAOrgjqZp1RU0wbImVm1bMLt0YyYT58w=; b=jvHndayovKeUtX9KhNDnrwvpHYFAY3TGK25k0jym2yigvLtNswLLxKT6Iy0gnikZPeX0Ea 9E+iGa5XeByTvqs/zPZqR1u20L7keWeogvvrl433gR3hgExeYnV91T9Q1Wb9KDJ4Ic91lH DRkHzMDCMUsHvHVQlZao+wq6tDL5sqbHKJOX/eVy2cbLpLzp/p7RhaKUdDs63DArSV80Nc /0UlofEZsEnKUE79VvJQDZOheJCmXNIeKvtMomamt0kJgN1KUChQ1Cxln1n7tKHWhQb3o5 kUdDzQD+B+oIiLbouzSjs/cLjOvw7xVyOynXPFGXyMx4hAB2VRXRIh8v5sZTtg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Aleksandr Shubin , linux-kernel@vger.kernel.org, Thierry Reding , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Cristian Ciocaltea , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org Subject: Re: [PATCH v6 0/3] Add support for Allwinner PWM on D1/T113s/R329 SoCs Message-ID: References: <20230824114038.891493-1-privatesub2@gmail.com> <20230921212736.nw6ctlimtrxfksbu@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230921212736.nw6ctlimtrxfksbu@pengutronix.de> X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Thu, Sep 21, 2023 at 11:27:36PM +0200, Uwe Kleine-König wrote: > Hi John, > > On Wed, Sep 06, 2023 at 12:46:19PM +1000, John Watts wrote: > > On Thu, Aug 24, 2023 at 02:40:24PM +0300, Aleksandr Shubin wrote: > > > This series adds support for PWM controller on new > > > Allwinner's SoCs, such as D1, T113s and R329. The implemented driver > > > provides basic functionality for control PWM channels. > > > > I have tested this patch and earlier versions successfully on a Mango Pi MQ > > Dual and verified it outputs a PWM signal. > > If you want that documented, the usual thing to do is to include a > Tested-by: tag in your reply. That's a good idea! I'll take a closer look under a scope and against the data sheet and give another tested-by then when I can. I'm not sure how close that gets to a reviewed-by but I don't have the experience in driver development to know if something is off in the design. > > Best regards > Uwe John.