From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mips: dts: ralink: mt7621: define each reset as an item
Date: Fri, 6 Oct 2023 10:22:14 +0200 [thread overview]
Message-ID: <ZR/Dtm0wTCa/V26h@alpha.franken.de> (raw)
In-Reply-To: <20230917103753.52644-1-arinc.unal@arinc9.com>
On Sun, Sep 17, 2023 at 01:37:53PM +0300, Arınç ÜNAL wrote:
> Each item of the resets property should define a reset. Split the item with
> two resets on the ethernet node into two separate items.
>
> Sort the items of the clocks property to the same line as a trivial change.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> arch/mips/boot/dts/ralink/mt7621.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index 7caed0d14f11..35a10258f235 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -300,14 +300,13 @@ ethernet: ethernet@1e100000 {
> compatible = "mediatek,mt7621-eth";
> reg = <0x1e100000 0x10000>;
>
> - clocks = <&sysc MT7621_CLK_FE>,
> - <&sysc MT7621_CLK_ETH>;
> + clocks = <&sysc MT7621_CLK_FE>, <&sysc MT7621_CLK_ETH>;
> clock-names = "fe", "ethif";
>
> #address-cells = <1>;
> #size-cells = <0>;
>
> - resets = <&sysc MT7621_RST_FE &sysc MT7621_RST_ETH>;
> + resets = <&sysc MT7621_RST_FE>, <&sysc MT7621_RST_ETH>;
> reset-names = "fe", "eth";
>
> interrupt-parent = <&gic>;
> --
> 2.39.2
>
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2023-10-06 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 10:37 [PATCH] mips: dts: ralink: mt7621: define each reset as an item Arınç ÜNAL
2023-09-18 8:29 ` Sergio Paracuellos
2023-10-06 8:22 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR/Dtm0wTCa/V26h@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).