devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: i2c: mxs: Pass ref and 'unevaluatedProperties: false'
@ 2023-09-23 19:26 Fabio Estevam
  2023-09-23 19:30 ` Krzysztof Kozlowski
  2023-09-25  6:21 ` Wolfram Sang
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-09-23 19:26 UTC (permalink / raw)
  To: andi.shyti
  Cc: robh+dt, krzysztof.kozlowski+dt, shawnguo, linux-imx, linux-i2c,
	devicetree, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Running 'make dtbs_check DT_SCHEMA_FILES=i2c-mxs.yaml' throws
several schema warnings such as:
 
imx28-m28evk.dtb: i2c@80058000: '#address-cells', '#size-cells', 'codec@a', 'eeprom@51', 'rtc@68' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/i2c/i2c-mxs.yaml#

Fix these warnings by passing a reference to i2c-controller.yaml#
and using 'unevaluatedProperties: false' just like the yaml bindings
of other I2C controllers.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/i2c/i2c-mxs.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml b/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml
index 21ae7bce038e..171a41407241 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml
@@ -9,6 +9,9 @@ title: Freescale MXS Inter IC (I2C) Controller
 maintainers:
   - Shawn Guo <shawnguo@kernel.org>
 
+allOf:
+  - $ref: /schemas/i2c/i2c-controller.yaml#
+
 properties:
   compatible:
     enum:
@@ -37,7 +40,7 @@ required:
   - dmas
   - dma-names
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: i2c: mxs: Pass ref and 'unevaluatedProperties: false'
  2023-09-23 19:26 [PATCH] dt-bindings: i2c: mxs: Pass ref and 'unevaluatedProperties: false' Fabio Estevam
@ 2023-09-23 19:30 ` Krzysztof Kozlowski
  2023-09-25  6:21 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-23 19:30 UTC (permalink / raw)
  To: Fabio Estevam, andi.shyti
  Cc: robh+dt, krzysztof.kozlowski+dt, shawnguo, linux-imx, linux-i2c,
	devicetree, Fabio Estevam

On 23/09/2023 21:26, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Running 'make dtbs_check DT_SCHEMA_FILES=i2c-mxs.yaml' throws
> several schema warnings such as:
>  
> imx28-m28evk.dtb: i2c@80058000: '#address-cells', '#size-cells', 'codec@a', 'eeprom@51', 'rtc@68' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/i2c/i2c-mxs.yaml#
> 
> Fix these warnings by passing a reference to i2c-controller.yaml#
> and using 'unevaluatedProperties: false' just like the yaml bindings
> of other I2C controllers.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: i2c: mxs: Pass ref and 'unevaluatedProperties: false'
  2023-09-23 19:26 [PATCH] dt-bindings: i2c: mxs: Pass ref and 'unevaluatedProperties: false' Fabio Estevam
  2023-09-23 19:30 ` Krzysztof Kozlowski
@ 2023-09-25  6:21 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2023-09-25  6:21 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: andi.shyti, robh+dt, krzysztof.kozlowski+dt, shawnguo, linux-imx,
	linux-i2c, devicetree, Fabio Estevam

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

On Sat, Sep 23, 2023 at 04:26:19PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Running 'make dtbs_check DT_SCHEMA_FILES=i2c-mxs.yaml' throws
> several schema warnings such as:
>  
> imx28-m28evk.dtb: i2c@80058000: '#address-cells', '#size-cells', 'codec@a', 'eeprom@51', 'rtc@68' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/i2c/i2c-mxs.yaml#
> 
> Fix these warnings by passing a reference to i2c-controller.yaml#
> and using 'unevaluatedProperties: false' just like the yaml bindings
> of other I2C controllers.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied to for-current, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-25  6:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-23 19:26 [PATCH] dt-bindings: i2c: mxs: Pass ref and 'unevaluatedProperties: false' Fabio Estevam
2023-09-23 19:30 ` Krzysztof Kozlowski
2023-09-25  6:21 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).