From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9D401B26E for ; Mon, 25 Sep 2023 14:43:40 +0000 (UTC) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62E46116 for ; Mon, 25 Sep 2023 07:43:39 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4054f790190so49673665e9.2 for ; Mon, 25 Sep 2023 07:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695653018; x=1696257818; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t/sMphRuA0VcjIhUu52wZChuZavyxtp56aeA36+PYxE=; b=aUOOreRInVc77su+vU68pq2DcBu5WxOTbtrNFudxrQ8+rlB7kQrHZIZAFzjaIGgW3D eT+c5NJqWpQELL9YvLEtchHONLQZ66xRMYZFFqofbmPmVtUJqTwz3cr/24e/yR2AAX+D ppuGlSUtnZn/ikZj/7SP5hL02ArrdVyNzxnXtW09BFh4qXgZmjDeqwj8Ya6oqbOUmL+4 dmGfwrf4+liTNGwnYco313nVsnld1qR1ZcvYf13ZOnp1lZj6FIHaIDicgzmyf9raCpqP lS6j1A7HaPGi4T/WrVpL7hgs0hI83sSJ4uPYWIReNGysu3eVDBCBra0UMPNAU6DIf3w6 k+jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695653018; x=1696257818; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t/sMphRuA0VcjIhUu52wZChuZavyxtp56aeA36+PYxE=; b=HIRzgvjI3IQatWb0q8HlyaQ1Hx4lZXMKB5xN8C7O3S7+5TlvVZbcwjf/Gd2Yq9iwNm 8+d7xeiSZjMy6Hb94wDq02Y7NjqBa3C+70OEU6djU7gzF/OoW6sXJh9gcoY+SarhKJj0 R1FhjWsfPwQ5d0gI/qw198tMeUyPuv/V4SoCOCIRGwjXRFEPesqfXAxK6l5lP8Virx7O GVfBn8FUl8uq8UMajX+zDZOh28AWEbwhDQf8GD/M30NyAypLIMbwonybcVmWK7au02OX GKELVOPwZUWOUBGuBGTISQwk+rIgft+DPhRejx7T/RHrcWYZDulND8rrLV0ugZOkt+Yu LqWw== X-Gm-Message-State: AOJu0YxNs6UVsRonH1K7K83xLpTXh9lQA6JKEseGqNIuEbBbNZGIgZjV 3Xp78qiA81x8RbKhKBRf3havlw== X-Google-Smtp-Source: AGHT+IEbGAlM/VewJdTcTv5/aTJRKALQYUm6lwgRKY3S9S1k9trypjsl9J42XlYhfQuHu1BmTqd4sg== X-Received: by 2002:a7b:cd07:0:b0:405:3ae6:2401 with SMTP id f7-20020a7bcd07000000b004053ae62401mr5847424wmj.14.1695653017666; Mon, 25 Sep 2023 07:43:37 -0700 (PDT) Received: from x1 ([193.52.24.5]) by smtp.gmail.com with ESMTPSA id n13-20020a7bc5cd000000b003fee53feab5sm12588862wmk.10.2023.09.25.07.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 07:43:37 -0700 (PDT) Date: Mon, 25 Sep 2023 16:43:29 +0200 From: Drew Fustini To: Adrian Hunter Cc: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jisheng Zhang , Guo Ren , Fu Wei , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Robert Nelson , Jason Kridner , Xi Ruoyao , Han Gao , Icenowy Zheng , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 3/6] mmc: sdhci-of-dwcmshc: Add support for T-Head TH1520 Message-ID: References: <20230921-th1520-mmc-v1-0-49f76c274fb3@baylibre.com> <20230921-th1520-mmc-v1-3-49f76c274fb3@baylibre.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Sep 25, 2023 at 01:35:36PM +0300, Adrian Hunter wrote: > On 22/09/23 04:49, Drew Fustini wrote: > > Add support for the mmc controller in the T-Head TH1520 with the new > > compatible "thead,th1520-dwcmshc". Implement custom sdhci_ops for > > set_uhs_signaling, reset, voltage_switch, and platform_execute_tuning. > > > > Signed-off-by: Drew Fustini > > --- > > drivers/mmc/host/sdhci-of-dwcmshc.c | 456 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 456 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c > > index 3a3bae6948a8..7294bf1afb7d 100644 > > --- a/drivers/mmc/host/sdhci-of-dwcmshc.c > > +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c > > @@ -35,6 +35,26 @@ > > #define DWCMSHC_CARD_IS_EMMC BIT(0) > > #define DWCMSHC_ENHANCED_STROBE BIT(8) > > #define DWCMSHC_EMMC_ATCTRL 0x40 > > +/* Tuning and auto-tuning fields in AT_CTRL_R control register */ > > +#define AT_CTRL_AT_EN 0x1 /* autotuning is enabled */ > > +#define AT_CTRL_CI_SEL_SHIFT 0x1 /* bit 1 */ > > +#define AT_CTRL_CI_SEL 0x1 /* interval to drive center phase select */ > > +#define AT_CTRL_SWIN_TH_EN_SHIFT 0x2 /* bit 2 */ > > +#define AT_CTRL_SWIN_TH_EN 0x1 /* sampling window threshold enable */ > > +#define AT_CTRL_RPT_TUNE_ERR_SHIFT 0x3 /* bit 3 */ > > +#define AT_CTRL_RPT_TUNE_ERR 0x1 /* enable reporting framing errors */ > > +#define AT_CTRL_SW_TUNE_EN_SHIFT 0x4 /* bit 4 */ > > +#define AT_CTRL_SW_TUNE_EN 0x1 /* enable software managed tuning */ > > +#define AT_CTRL_WIN_EDGE_SEL_SHIFT 0x8 /* bits [11:8] */ > > +#define AT_CTRL_WIN_EDGE_SEL 0xf /* sampling window edge select */ > > +#define AT_CTRL_TUNE_CLK_STOP_EN_SHIFT 0x10 /* bit 16 */ > > +#define AT_CTRL_TUNE_CLK_STOP_EN 0x1 /* clocks stopped during phase code change */ > > +#define AT_CTRL_PRE_CHANGE_DLY_SHIFT 0x11 /* bits [18:17] */ > > +#define AT_CTRL_PRE_CHANGE_DLY 0x1 /* 2-cycle latency */ > > +#define AT_CTRL_POST_CHANGE_DLY_SHIFT 0x13 /* bits [20:19] */ > > +#define AT_CTRL_POST_CHANGE_DLY 0x3 /* 4-cycle latency */ > > +#define AT_CTRL_SWIN_TH_VAL_SHIFT 0x18 /* bits [31:24] */ > > +#define AT_CTRL_SWIN_TH_VAL 0x9 /* sampling window threshold */ > > Here and elsewhere, please try to make use of BIT(), GENMASK(), > FIELD_PREP(), FIELD_GET() Thank you for the advice. FIELD_PREP() and FIELD_GET() look like they can make the code simpler. I'll make use of those macros in the next version. thanks, drew