* [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes
@ 2023-09-26 16:43 Rob Herring
2023-09-27 1:47 ` Marcelo Schmitt
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring @ 2023-09-26 16:43 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Marcelo Schmitt,
Jonathan Cameron, Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, devicetree, linux-kernel
"additionalProperties: true" is only for incomplete schemas such as bus
child nodes in a bus's schema. That doesn't apply to the "channel" nodes
in the adi,ad7292 binding, so fix additionalProperties to be false.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
index 7cc4ddc4e9b7..2aa1f4b063eb 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
@@ -61,7 +61,7 @@ patternProperties:
required:
- reg
- additionalProperties: true
+ additionalProperties: false
allOf:
- $ref: /schemas/spi/spi-peripheral-props.yaml#
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes
2023-09-26 16:43 [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes Rob Herring
@ 2023-09-27 1:47 ` Marcelo Schmitt
2023-09-27 15:14 ` Conor Dooley
2023-09-30 16:46 ` Jonathan Cameron
2 siblings, 0 replies; 4+ messages in thread
From: Marcelo Schmitt @ 2023-09-27 1:47 UTC (permalink / raw)
To: Rob Herring
Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Krzysztof Kozlowski, Conor Dooley, linux-iio, devicetree,
linux-kernel
On 09/26, Rob Herring wrote:
> "additionalProperties: true" is only for incomplete schemas such as bus
> child nodes in a bus's schema. That doesn't apply to the "channel" nodes
> in the adi,ad7292 binding, so fix additionalProperties to be false.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Thanks,
Marcelo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes
2023-09-26 16:43 [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes Rob Herring
2023-09-27 1:47 ` Marcelo Schmitt
@ 2023-09-27 15:14 ` Conor Dooley
2023-09-30 16:46 ` Jonathan Cameron
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2023-09-27 15:14 UTC (permalink / raw)
To: Rob Herring
Cc: Lars-Peter Clausen, Michael Hennerich, Marcelo Schmitt,
Jonathan Cameron, Krzysztof Kozlowski, Conor Dooley, linux-iio,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 52 bytes --]
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes
2023-09-26 16:43 [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes Rob Herring
2023-09-27 1:47 ` Marcelo Schmitt
2023-09-27 15:14 ` Conor Dooley
@ 2023-09-30 16:46 ` Jonathan Cameron
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2023-09-30 16:46 UTC (permalink / raw)
To: Rob Herring
Cc: Lars-Peter Clausen, Michael Hennerich, Marcelo Schmitt,
Krzysztof Kozlowski, Conor Dooley, linux-iio, devicetree,
linux-kernel
On Tue, 26 Sep 2023 11:43:50 -0500
Rob Herring <robh@kernel.org> wrote:
> "additionalProperties: true" is only for incomplete schemas such as bus
> child nodes in a bus's schema. That doesn't apply to the "channel" nodes
> in the adi,ad7292 binding, so fix additionalProperties to be false.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Oops.
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> ---
> Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
> index 7cc4ddc4e9b7..2aa1f4b063eb 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
> @@ -61,7 +61,7 @@ patternProperties:
> required:
> - reg
>
> - additionalProperties: true
> + additionalProperties: false
>
> allOf:
> - $ref: /schemas/spi/spi-peripheral-props.yaml#
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-30 16:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-26 16:43 [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes Rob Herring
2023-09-27 1:47 ` Marcelo Schmitt
2023-09-27 15:14 ` Conor Dooley
2023-09-30 16:46 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).