From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A47933D6; Wed, 27 Sep 2023 07:18:11 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FE0011D; Wed, 27 Sep 2023 00:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695799090; x=1727335090; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3lvZvOml3+lEkRnYV3uf47vqcra7BFoLiBhptCYXrwk=; b=PYY6nDg/HE0YT/Gk9TlMuBhZWRevzNQNj2VbkSG7WXn8RE9ORp8d2IFa C0qXgfYSeJSGG75zek2BfwaLpBFQPXrwAAsMI0uqwzYquM/sKXTpORf8/ F5cQYEzqniycoVv/fM7W9yOpmfgLaX1MZuIKlS05PJ/lj451w6gJKKVk+ lnSuj8Rc+c4bQ0qO1NMzklCBGhymJKAbAXW4y7PZQi3OYSN4davZT1nGx U+ad7TN2D3mTvRSASLQAEJfsrF56lvrjZ92IQMI8CYGJ3gKlkrSqGLAgu L77F6patHAR7iqfbCfmY4fqder0XdALrmta2w9J+Qa+AoQFLIg6E7VrNo A==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="381652801" X-IronPort-AV: E=Sophos;i="6.03,179,1694761200"; d="scan'208";a="381652801" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2023 00:18:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="819319694" X-IronPort-AV: E=Sophos;i="6.03,179,1694761200"; d="scan'208";a="819319694" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga004.fm.intel.com with SMTP; 27 Sep 2023 00:18:05 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 27 Sep 2023 10:18:04 +0300 Date: Wed, 27 Sep 2023 10:18:04 +0300 From: Heikki Krogerus To: Abdel Alkuor Cc: krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org, gregkh@linuxfoundation.org, robh+dt@kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, conor+dt@kernel.org, ryan.eleceng@gmail.com Subject: Re: [PATCH v6 02/14] USB: typec: Add cmd timeout and response delay Message-ID: References: <20230923073959.86660-1-alkuor@gmail.com> <20230923073959.86660-3-alkuor@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Sep 27, 2023 at 10:00:50AM +0300, Heikki Krogerus wrote: > On Sat, Sep 23, 2023 at 03:39:47AM -0400, Abdel Alkuor wrote: > > Some commands in tps25750 take longer than 1 second > > to complete, and some responses need some delay before > > the result becomes available. > > > > Signed-off-by: Abdel Alkuor > > Reviewed-by: Heikki Krogerus Hold on! You are not specifying the driver in the subject. You need to fix that. > > --- > > Changes in v6: > > - Use tps6598x_exec_cmd as a wrapper > > Changes in v5: > > - Incorporating tps25750 into tps6598x driver > > > > drivers/usb/typec/tipd/core.c | 19 +++++++++++++++---- > > 1 file changed, 15 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > > index 37b56ce75f39..32420c61660d 100644 > > --- a/drivers/usb/typec/tipd/core.c > > +++ b/drivers/usb/typec/tipd/core.c > > @@ -282,9 +282,10 @@ static void tps6598x_disconnect(struct tps6598x *tps, u32 status) > > power_supply_changed(tps->psy); > > } > > > > -static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd, > > +static int tps6598x_exec_cmd_tmo(struct tps6598x *tps, const char *cmd, > > size_t in_len, u8 *in_data, > > - size_t out_len, u8 *out_data) > > + size_t out_len, u8 *out_data, > > + u32 cmd_timeout_ms, u32 res_delay_ms) > > { > > unsigned long timeout; > > u32 val; > > @@ -307,8 +308,7 @@ static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd, > > if (ret < 0) > > return ret; > > > > - /* XXX: Using 1s for now, but it may not be enough for every command. */ > > - timeout = jiffies + msecs_to_jiffies(1000); > > + timeout = jiffies + msecs_to_jiffies(cmd_timeout_ms); > > > > do { > > ret = tps6598x_read32(tps, TPS_REG_CMD1, &val); > > @@ -321,6 +321,9 @@ static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd, > > return -ETIMEDOUT; > > } while (val); > > > > + /* some commands require delay for the result to be available */ > > + mdelay(res_delay_ms); > > + > > if (out_len) { > > ret = tps6598x_block_read(tps, TPS_REG_DATA1, > > out_data, out_len); > > @@ -345,6 +348,14 @@ static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd, > > return 0; > > } > > > > +static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd, > > + size_t in_len, u8 *in_data, > > + size_t out_len, u8 *out_data) > > +{ > > + return tps6598x_exec_cmd_tmo(tps, cmd, in_len, in_data, > > + out_len, out_data, 1000, 0); > > +} > > + > > static int tps6598x_dr_set(struct typec_port *port, enum typec_data_role role) > > { > > const char *cmd = (role == TYPEC_DEVICE) ? "SWUF" : "SWDF"; > > -- > > 2.34.1 > > -- > heikki -- heikki