devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Abdel Alkuor <alkuor@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org,
	gregkh@linuxfoundation.org, robh+dt@kernel.org,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, conor+dt@kernel.org,
	ryan.eleceng@gmail.com
Subject: Re: [PATCH v6 02/14] USB: typec: Add cmd timeout and response delay
Date: Wed, 27 Sep 2023 03:47:00 -0400	[thread overview]
Message-ID: <ZRPd9IHwBsDOJqJv@primary> (raw)
In-Reply-To: <ZRPXLBj/Y6+yiwf8@kuha.fi.intel.com>

On Wed, Sep 27, 2023 at 10:18:04AM +0300, Heikki Krogerus wrote:
> On Wed, Sep 27, 2023 at 10:00:50AM +0300, Heikki Krogerus wrote:
> > On Sat, Sep 23, 2023 at 03:39:47AM -0400, Abdel Alkuor wrote:
> > > Some commands in tps25750 take longer than 1 second
> > > to complete, and some responses need some delay before
> > > the result becomes available.
> > > 
> > > Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
> > 
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> 
> Hold on!
> 
> You are not specifying the driver in the subject. You need to fix
> that.
> 
I will send new patches with their subject updated.

Thanks,
Abdel

  reply	other threads:[~2023-09-27  7:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-23  7:39 [PATCH v6 00/14] Add TPS25750 USB type-C PD controller support Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 01/14] dt-bindings: usb: tps6598x: Add tps25750 Abdel Alkuor
2023-09-23 11:49   ` Krzysztof Kozlowski
2023-09-23  7:39 ` [PATCH v6 02/14] USB: typec: Add cmd timeout and response delay Abdel Alkuor
2023-09-27  7:00   ` Heikki Krogerus
2023-09-27  7:18     ` Heikki Krogerus
2023-09-27  7:47       ` Abdel Alkuor [this message]
2023-09-23  7:39 ` [PATCH v6 03/14] USB: typec: Add patch mode to tps6598x Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 04/14] USB: typec: Load TPS25750 patch bundle Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 05/14] USB: typec: Check for EEPROM present Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 06/14] USB: typec: Clear dead battery flag Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 07/14] USB: typec: Apply patch again after power resume Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 08/14] USB: typec: Add interrupt support for TPS25750 Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 09/14] USB: typec: Refactor tps6598x port registration Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 10/14] USB: typec: Add port registration for tps25750 Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 11/14] USB: typec: Enable sleep mode " Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 12/14] USB: typec: Add trace for tps25750 irq Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 13/14] USB: typec: Add power status trace for tps25750 Abdel Alkuor
2023-09-23  7:39 ` [PATCH v6 14/14] USB: typec: Add " Abdel Alkuor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRPd9IHwBsDOJqJv@primary \
    --to=alkuor@gmail.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ryan.eleceng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).