From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E3F523AA for ; Sat, 30 Sep 2023 09:39:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3F32C433C8; Sat, 30 Sep 2023 09:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696066746; bh=Q0JZczSYb8IZ3ZaIjrDmyo/SCG/lFxNpe9cqL4DbR9M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g+k2A1eNMfAUeB5DhoWwL0EcXnfvkO3LYkHPCNZ6AaOWavJXdXi9qgXvIrPkgG4TH Lm2oItzKRv/D3E1Des2qSA4uhu7blxdjCoTGBA1YT+Chx+jqKS8/rBqbH6Cnb2WPol bg4eVvmc6tGtD4BhUy2dM5ivJHif4D72tG5Y7ZHpI/xz8V177BZacFljJPmCwfXDhf sLyuLxt8gVz7pohq8ri9EJj6b4IW9VxMOaDz4VEZVnKvmWiI0k0hY8iX2DEknPwaaa ahPmvj+62FRuaRb0pqCLVsnpo5I49mnRT5vysMOrRHaQDKporyTcHWpg1tBpshN4mH tqBED0oKI406w== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qmWRI-0001Ou-0P; Sat, 30 Sep 2023 11:39:08 +0200 Date: Sat, 30 Sep 2023 11:39:08 +0200 From: Johan Hovold To: Konrad Dybcio Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Vinod Koul , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 2/2] clk: qcom: gcc-sc8280xp: Don't keep display AHB clocks always-on Message-ID: References: <20230929-topic-8280_ahbdisp-v1-0-72bdc38309b9@linaro.org> <20230929-topic-8280_ahbdisp-v1-2-72bdc38309b9@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929-topic-8280_ahbdisp-v1-2-72bdc38309b9@linaro.org> On Fri, Sep 29, 2023 at 03:38:53PM +0200, Konrad Dybcio wrote: > These clocks are consumed by the dispcc[01] clock controllers, so there's > no reason to keep them on from gcc probe. Remove that hack. Eh, how did you test this patch? The GCC_DISP_AHB_CLK clocks are not modelled by the clock driver currently so nothing is guaranteeing them to be enabled if we were to apply this patch. They just happen to be left on by the bootloader on some machines currently (well at least one of them is on one machine). So this series is broken and should not be applied. NAK. Also, please CC me on sc8280xp and X13s related patches. > Fixes: d65d005f9a6c ("clk: qcom: add sc8280xp GCC driver") > Signed-off-by: Konrad Dybcio > --- > drivers/clk/qcom/gcc-sc8280xp.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c > index bfb77931e868..bf95f82a3818 100644 > --- a/drivers/clk/qcom/gcc-sc8280xp.c > +++ b/drivers/clk/qcom/gcc-sc8280xp.c > @@ -7545,18 +7545,16 @@ static int gcc_sc8280xp_probe(struct platform_device *pdev) > > /* > * Keep the clocks always-ON > - * GCC_CAMERA_AHB_CLK, GCC_CAMERA_XO_CLK, GCC_DISP_AHB_CLK, > + * GCC_CAMERA_AHB_CLK, GCC_CAMERA_XO_CLK, > * GCC_DISP_XO_CLK, GCC_GPU_CFG_AHB_CLK, GCC_VIDEO_AHB_CLK, > - * GCC_VIDEO_XO_CLK, GCC_DISP1_AHB_CLK, GCC_DISP1_XO_CLK > + * GCC_VIDEO_XO_CLK, GCC_DISP1_XO_CLK > */ > regmap_update_bits(regmap, 0x26004, BIT(0), BIT(0)); > regmap_update_bits(regmap, 0x26020, BIT(0), BIT(0)); > - regmap_update_bits(regmap, 0x27004, BIT(0), BIT(0)); > regmap_update_bits(regmap, 0x27028, BIT(0), BIT(0)); > regmap_update_bits(regmap, 0x71004, BIT(0), BIT(0)); > regmap_update_bits(regmap, 0x28004, BIT(0), BIT(0)); > regmap_update_bits(regmap, 0x28028, BIT(0), BIT(0)); > - regmap_update_bits(regmap, 0xbb004, BIT(0), BIT(0)); > regmap_update_bits(regmap, 0xbb028, BIT(0), BIT(0)); Johan