From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C342208D7; Tue, 3 Oct 2023 11:13:28 +0000 (UTC) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DCD71AE; Tue, 3 Oct 2023 04:13:19 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-52fe27898e9so1374409a12.0; Tue, 03 Oct 2023 04:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696331598; x=1696936398; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3luBE338An7uOAk1OcMGKWBZ5Pr4mpK2fSSvbg0/GeI=; b=FNWCkj8U/ozz1LPvm931aoFp4WDaDJw4UPG85WorGF55+CbITOH54mYQjUa2EyUvPD P+1cNhHPeGCUHdxLvThl0Ux5wuB36B3rlqTVEqhjUe7kIHGm5IxhMdpo8rSWNMAqFI1S 46eU88i0O4nqrH0GXVRdeoEIQSILl94iSLeiTbVDTSqqMvBwynM+w7F55rzSRri2FV/e HWBVeV3WZuIBmsmN23RjhPU2ZEbz/YjRiMz61Cl5FUO3UvblCCLU3bE5EEz6kCSKz/yB qFQ56wcS+ttS3RQ2oyAiat9aWWipVklXNhCZnbSQjlnEKkByRg9+mtJY5cIU/XznP/e1 7CYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696331598; x=1696936398; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3luBE338An7uOAk1OcMGKWBZ5Pr4mpK2fSSvbg0/GeI=; b=FFEn/n4vgIJnGu4XplSmH1NRYq5JQGCsraFWi9/pANrejHY++SgLt/dWEDIFGWHfjs ag9pIBiGNbEfmyNJYdNsjbWcAQ0+3wRwEk8ZVHA29MEzU21bYwVBqIPnuOxfwijUG+xy UPawjfDv+Ez/jzPhSts1vzohUZqmjjGNQ/IvhcAhInXETP/3hNt54/gAzpIvakFfYf7Q zNye/6OgTEZMWRh6O7szRDgIMEGI0MLV6CmfvqJ0tWcgn4wIqLIGUkYl/3UxhfZt3pmG WN62RWZE4EtSacSSIlaKumqQgOjKQhqKr3DrgYlCO+7NcDOtpPiJDazZctiLpZm7Jamw xhiA== X-Gm-Message-State: AOJu0YwA5/LSg1DErCNUJUPph2kXF+p5Lv4nb1M9pyowpi4GqAiRm6SN O9Ck0NhODa7DntdxtkEb8OI= X-Google-Smtp-Source: AGHT+IFeDp0mkXJrBV8uMZLCnlL2zxKWcJdDm1Xibz4bWonczwbYahjEkyal9T7Iwjo5D+2KDydyew== X-Received: by 2002:aa7:cf92:0:b0:531:2b7c:513a with SMTP id z18-20020aa7cf92000000b005312b7c513amr11412427edx.17.1696331597567; Tue, 03 Oct 2023 04:13:17 -0700 (PDT) Received: from primary ([213.139.52.198]) by smtp.gmail.com with ESMTPSA id r6-20020aa7da06000000b005346bebc2a5sm698603eds.86.2023.10.03.04.13.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 04:13:17 -0700 (PDT) Date: Tue, 3 Oct 2023 07:13:13 -0400 From: Abdel Alkuor To: Heikki Krogerus Cc: krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ryan.eleceng@gmail.com, robh+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, Abdel Alkuor Subject: Re: [PATCH v9 06/14] USB: typec: tps6598x: Clear dead battery flag Message-ID: References: <20231001081134.37101-1-alkuor@gmail.com> <20231001081134.37101-7-alkuor@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Oct 03, 2023 at 09:03:42AM +0300, Heikki Krogerus wrote: > On Sun, Oct 01, 2023 at 04:11:26AM -0400, Abdel Alkuor wrote: > > From: Abdel Alkuor > > > > Dead battery flag must be cleared after switching tps25750 to APP mode > > so the PD controller becomes fully functional. > > > > Signed-off-by: Abdel Alkuor > > I'm sorry I noticed these so late, but this one really feels like it > should be part of the patch 4/14. Is there some reason why you do this > separately? > That's a good. There is no actual reason, it was just simply part of the implementation flow. I will move it to be part the patch that supports tps25750 implementation Thanks, Abdel > Br, > > -- > heikki