From: Abdel Alkuor <alkuor@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, ryan.eleceng@gmail.com,
robh+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, Abdel Alkuor <abdelalkuor@geotab.com>
Subject: Re: [PATCH v9 07/14] USB: typec: tps6598x: Apply patch again after power resume
Date: Tue, 3 Oct 2023 07:14:47 -0400 [thread overview]
Message-ID: <ZRv3pz6E5Jc48VxL@primary> (raw)
In-Reply-To: <ZRuy1NqA/VfWbBWn@kuha.fi.intel.com>
On Tue, Oct 03, 2023 at 09:21:08AM +0300, Heikki Krogerus wrote:
> On Sun, Oct 01, 2023 at 04:11:27AM -0400, Abdel Alkuor wrote:
> > From: Abdel Alkuor <abdelalkuor@geotab.com>
> >
> > TPS25750 PD controller might be powered off externally at power suspend,
> > after resuming PD controller power back, apply the patch again.
> >
> > Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>
>
> This one looks also like something that should be part of the patch 4.
>
> My concern is that with these separated features you are creating points
> into the kernel git tree where TPS25750 is enabled, but it's not fully
> functional, or even broken in scenarious like this (suspend/resume).
> You can't do that unless you have some really good reason.
>
> Since all of these add only a bit of code each, I think it would be
> better to just merge these into the initial patch that enabled
> TPS25750 - so I belive patch 4/14.
>
Makes a lot of sense. I will add part of full tps25750 support patch
> --
> heikki
Thanks,
Abdel
next prev parent reply other threads:[~2023-10-03 11:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 8:11 [PATCH v9 00/14] Add TPS25750 USB type-C PD controller support Abdel Alkuor
2023-10-01 8:11 ` [PATCH v9 01/14] dt-bindings: usb: tps6598x: Add tps25750 Abdel Alkuor
2023-10-01 8:11 ` [PATCH v9 02/14] USB: typec: tsp6598x: Add cmd timeout and response delay Abdel Alkuor
2023-10-01 8:11 ` [PATCH v9 03/14] USB: typec: tps6598x: Add patch mode to tps6598x Abdel Alkuor
2023-10-03 5:28 ` Heikki Krogerus
2023-10-01 8:11 ` [PATCH v9 04/14] USB: typec: tps6598x: Load TPS25750 patch bundle Abdel Alkuor
2023-10-03 5:30 ` Heikki Krogerus
2023-10-03 7:01 ` Heikki Krogerus
2023-10-01 8:11 ` [PATCH v9 05/14] USB: typec: tps6598x: Check for EEPROM present Abdel Alkuor
2023-10-03 5:34 ` Heikki Krogerus
2023-10-03 11:11 ` Abdel Alkuor
2023-10-01 8:11 ` [PATCH v9 06/14] USB: typec: tps6598x: Clear dead battery flag Abdel Alkuor
2023-10-03 6:03 ` Heikki Krogerus
2023-10-03 11:13 ` Abdel Alkuor
2023-10-01 8:11 ` [PATCH v9 07/14] USB: typec: tps6598x: Apply patch again after power resume Abdel Alkuor
2023-10-03 6:21 ` Heikki Krogerus
2023-10-03 11:14 ` Abdel Alkuor [this message]
2023-10-01 8:11 ` [PATCH v9 08/14] USB: typec: tps6598x: Add interrupt support for TPS25750 Abdel Alkuor
2023-10-03 6:39 ` Heikki Krogerus
2023-10-03 11:18 ` Abdel Alkuor
2023-10-01 8:11 ` [PATCH v9 09/14] USB: typec: tps6598x: Refactor tps6598x port registration Abdel Alkuor
2023-10-03 6:43 ` Heikki Krogerus
2023-10-01 8:11 ` [PATCH v9 10/14] USB: typec: tps6598x: Add port registration for tps25750 Abdel Alkuor
2023-10-03 6:50 ` Heikki Krogerus
2023-10-01 8:11 ` [PATCH v9 11/14] USB: typec: tps6598x: Enable sleep mode " Abdel Alkuor
2023-10-01 8:11 ` [PATCH v9 12/14] USB: typec: tps6598x: Add trace for tps25750 irq Abdel Alkuor
2023-10-01 8:11 ` [PATCH v9 13/14] USB: typec: tps6598x: Add power status trace for tps25750 Abdel Alkuor
2023-10-01 8:11 ` [PATCH v9 14/14] USB: typec: tps6598x: Add " Abdel Alkuor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRv3pz6E5Jc48VxL@primary \
--to=alkuor@gmail.com \
--cc=abdelalkuor@geotab.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan.eleceng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).