From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Fabio Estevam <festevam@gmail.com>,
martink@posteo.de
Subject: Re: [PATCH v3 1/7] media: dt-bindings: hynix,hi846: Add video-interface-device properties
Date: Tue, 3 Oct 2023 08:27:30 +0000 [thread overview]
Message-ID: <ZRvQckwdt9modLss@kekkonen.localdomain> (raw)
In-Reply-To: <20230930145951.23433-2-jacopo.mondi@ideasonboard.com>
Hi Jacopo,
On Sat, Sep 30, 2023 at 04:59:45PM +0200, Jacopo Mondi wrote:
> Allow properties from video-interface-device.yaml for the SK Hynix Hi-846
> sensor.
>
> All properties specified in video-interface-device.yaml schema are
> valid, so make them accepted by changing "additionalProperties: false"
> to "unevaluatedProperties: false" at the schema top-level.
The patch seems fine to me, but I wonder if we should change the title of
video-interface-devices.yaml (it's plural) to something that refers to
camera sensors, and possibly split it. It's currently not relevant for
other types of devices.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2023-10-03 8:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 14:59 [PATCH v3 0/7] media: bindings: Fix handling of video-interface-device Jacopo Mondi
2023-09-30 14:59 ` [PATCH v3 1/7] media: dt-bindings: hynix,hi846: Add video-interface-device properties Jacopo Mondi
2023-10-02 19:17 ` Rob Herring
2023-10-03 8:27 ` Sakari Ailus [this message]
2023-10-03 9:15 ` Laurent Pinchart
2023-09-30 14:59 ` [PATCH v3 2/7] media: dt-bindings: hynix,hi846: Restrict endpoint properties Jacopo Mondi
2023-10-02 19:17 ` Rob Herring
2023-09-30 14:59 ` [PATCH v3 3/7] media: dt-bindings: ovti,ov02a10: Fix handling of video-interface-device Jacopo Mondi
2023-10-02 19:17 ` Rob Herring
2023-09-30 14:59 ` [PATCH v3 4/7] media: dt-bindings: ovti,ov4689: " Jacopo Mondi
2023-10-02 19:18 ` Rob Herring
2023-09-30 14:59 ` [PATCH v3 5/7] media: dt-bindings: ovti,ov5640: " Jacopo Mondi
2023-10-02 19:18 ` Rob Herring
2023-09-30 14:59 ` [PATCH v3 6/7] media: dt-bindings: sony,imx214: " Jacopo Mondi
2023-10-02 19:18 ` Rob Herring
2023-09-30 14:59 ` [PATCH v3 7/7] media: dt-bindings: sony,imx415: " Jacopo Mondi
2023-10-02 19:07 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRvQckwdt9modLss@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=martink@posteo.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox