From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Abdel Alkuor <alkuor@gmail.com>
Cc: krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, ryan.eleceng@gmail.com,
robh+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, Abdel Alkuor <abdelalkuor@geotab.com>
Subject: Re: [PATCH v10 7/9] USB: typec: tps6598x: Add trace for tps25750 irq
Date: Tue, 10 Oct 2023 08:58:11 +0300 [thread overview]
Message-ID: <ZSTn82ftBzUYVWPQ@kuha.fi.intel.com> (raw)
In-Reply-To: <20231003155842.57313-8-alkuor@gmail.com>
On Tue, Oct 03, 2023 at 11:58:40AM -0400, Abdel Alkuor wrote:
> From: Abdel Alkuor <abdelalkuor@geotab.com>
>
> tps25750 event1 register doesn't have all bits in tps6598x
> event registers, only show the events that are masked
>
> Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Changes in v10:
> - Move 0012-USB-typec-tps6598x-Add-trace-for-tps25750-irq.patch to patch 7
> Changes in v9:
> - No changes
> Changes in v8:
> - Use device_is_compatible instead of of_device_is_compatible
> Changes in v7:
> - Add driver name to commit subject
> Changes in v6:
> - Check tps25750 using is_compatiable device node
> Changes in v5:
> - Incorporating tps25750 into tps6598x driver
> drivers/usb/typec/tipd/core.c | 1 +
> drivers/usb/typec/tipd/trace.h | 22 ++++++++++++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 892432ad80a3..e0ff6fc9f256 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -589,6 +589,7 @@ static irqreturn_t tps25750_interrupt(int irq, void *data)
> dev_err(tps->dev, "%s: failed to read events\n", __func__);
> goto err_unlock;
> }
> + trace_tps25750_irq(event[0]);
>
> if (!(event[0] | event[1]))
> goto err_unlock;
> diff --git a/drivers/usb/typec/tipd/trace.h b/drivers/usb/typec/tipd/trace.h
> index 12cad1bde7cc..28725234a2d8 100644
> --- a/drivers/usb/typec/tipd/trace.h
> +++ b/drivers/usb/typec/tipd/trace.h
> @@ -74,6 +74,13 @@
> { APPLE_CD_REG_INT_DATA_STATUS_UPDATE, "DATA_STATUS_UPDATE" }, \
> { APPLE_CD_REG_INT_STATUS_UPDATE, "STATUS_UPDATE" })
>
> +#define show_tps25750_irq_flags(flags) \
> + __print_flags_u64(flags, "|", \
> + { TPS_REG_INT_PLUG_EVENT, "PLUG_EVENT" }, \
> + { TPS_REG_INT_POWER_STATUS_UPDATE, "POWER_STATUS_UPDATE" }, \
> + { TPS_REG_INT_STATUS_UPDATE, "STATUS_UPDATE" }, \
> + { TPS_REG_INT_PD_STATUS_UPDATE, "PD_STATUS_UPDATE" })
> +
> #define TPS6598X_STATUS_FLAGS_MASK (GENMASK(31, 0) ^ (TPS_STATUS_CONN_STATE_MASK | \
> TPS_STATUS_PP_5V0_SWITCH_MASK | \
> TPS_STATUS_PP_HV_SWITCH_MASK | \
> @@ -230,6 +237,21 @@ TRACE_EVENT(cd321x_irq,
> show_cd321x_irq_flags(__entry->event))
> );
>
> +TRACE_EVENT(tps25750_irq,
> + TP_PROTO(u64 event),
> + TP_ARGS(event),
> +
> + TP_STRUCT__entry(
> + __field(u64, event)
> + ),
> +
> + TP_fast_assign(
> + __entry->event = event;
> + ),
> +
> + TP_printk("event=%s", show_tps25750_irq_flags(__entry->event))
> +);
> +
> TRACE_EVENT(tps6598x_status,
> TP_PROTO(u32 status),
> TP_ARGS(status),
> --
> 2.34.1
--
heikki
next prev parent reply other threads:[~2023-10-10 5:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 15:58 [PATCH v10 00/14] Add TPS25750 USB type-C PD controller support Abdel Alkuor
2023-10-03 15:58 ` [PATCH v10 1/9] dt-bindings: usb: tps6598x: Add tps25750 Abdel Alkuor
2023-10-03 15:58 ` [PATCH v10 2/9] USB: typec: tsp6598x: Add cmd timeout and response delay Abdel Alkuor
2023-10-03 15:58 ` [PATCH v10 3/9] USB: typec: tps6598x: Add patch mode to tps6598x Abdel Alkuor
2023-10-03 15:58 ` [PATCH v10 4/9] USB: typec: tps6598x: Refactor tps6598x port registration Abdel Alkuor
2023-10-03 15:58 ` [PATCH v10 5/9] USB: typec: tps6598x: Add device data to of_device_id Abdel Alkuor
2023-10-10 5:55 ` Heikki Krogerus
2023-10-03 15:58 ` [PATCH v10 6/9] USB: typec: tps6598x: Add TPS25750 support Abdel Alkuor
2023-10-10 5:57 ` Heikki Krogerus
2023-10-03 15:58 ` [PATCH v10 7/9] USB: typec: tps6598x: Add trace for tps25750 irq Abdel Alkuor
2023-10-10 5:58 ` Heikki Krogerus [this message]
2023-10-03 15:58 ` [PATCH v10 8/9] USB: typec: tps6598x: Add power status trace for tps25750 Abdel Alkuor
2023-10-10 5:58 ` Heikki Krogerus
2023-10-03 15:58 ` [PATCH v10 9/9] USB: typec: tps6598x: Add " Abdel Alkuor
2023-10-10 5:59 ` Heikki Krogerus
2023-10-10 7:02 ` [PATCH v10 00/14] Add TPS25750 USB type-C PD controller support Greg KH
2023-10-10 11:09 ` Abdel Alkuor
2023-10-10 11:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSTn82ftBzUYVWPQ@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=abdelalkuor@geotab.com \
--cc=alkuor@gmail.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan.eleceng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).