From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-x13s: Use the correct DP PHY compatible
Date: Mon, 16 Oct 2023 11:01:47 +0200 [thread overview]
Message-ID: <ZSz7---IW_7Oj2Zr@hovoldconsulting.com> (raw)
In-Reply-To: <CAA8EJprXCzVyaU49qgVcVfF0-FJ3QqAfTMZj5CEZm187hoi4=g@mail.gmail.com>
On Mon, Oct 16, 2023 at 11:51:33AM +0300, Dmitry Baryshkov wrote:
> On Fri, 29 Sept 2023 at 19:03, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> >
> > The DP PHY needs different settings when an eDP display is used.
> > Make sure these apply on the X13s.
>
> Could you please clarify, is it the same PHY type, just being
> repurposed for eDP or is it a different PHY type?
Same PHY, just different settings AFAIK.
> If the former is the case (and the same PHY can be used for both DP
> and eDP), it should carry the same compatible string and use software
> mechanisms (e.g. phy_set_mode_ext()) to be programmed for the correct
> operation mode.
Possibly, but that's not how the current binding and implementation
works:
6993c079cd58 ("dt-bindings: phy: qcom-edp: Add SC8280XP PHY compatibles")
2300d1cb24b3 ("phy: qcom: edp: Introduce support for DisplayPort")
3b7267dec445 ("phy: qcom: edp: Add SC8280XP eDP and DP PHYs")
https://lore.kernel.org/lkml/20220810040745.3582985-1-bjorn.andersson@linaro.org/
And you'd still need to infer the mode from DT somehow.
Johan
next prev parent reply other threads:[~2023-10-16 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 16:02 [PATCH] arm64: dts: qcom: sc8280xp-x13s: Use the correct DP PHY compatible Konrad Dybcio
2023-10-02 8:54 ` Johan Hovold
2023-10-16 8:12 ` Johan Hovold
2023-10-16 8:51 ` Dmitry Baryshkov
2023-10-16 9:01 ` Johan Hovold [this message]
2023-10-16 9:10 ` Dmitry Baryshkov
2023-10-17 3:28 ` Bjorn Andersson
2023-10-17 16:22 ` Konrad Dybcio
2023-10-22 15:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSz7---IW_7Oj2Zr@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).