* [PATCH] arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible
@ 2023-10-16 8:06 Johan Hovold
2023-10-16 8:53 ` Dmitry Baryshkov
2023-12-03 4:54 ` Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Johan Hovold @ 2023-10-16 8:06 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
Johan Hovold, stable
The sc8280xp Display Port PHYs can be used in either DP or eDP mode and
this is configured using the devicetree compatible string which defaults
to DP mode in the SoC dtsi.
Override the default compatible string for the CRD eDP PHY node so that
the eDP settings are used.
Fixes: 4a883a8d80b5 ("arm64: dts: qcom: sc8280xp-crd: Enable EDP")
Cc: stable@vger.kernel.org # 6.3
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
index 772953dc428e..31a2a2d27f4e 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
@@ -458,6 +458,8 @@ mdss0_dp3_out: endpoint {
};
&mdss0_dp3_phy {
+ compatible = "qcom,sc8280xp-edp-phy";
+
vdda-phy-supply = <&vreg_l6b>;
vdda-pll-supply = <&vreg_l3b>;
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible
2023-10-16 8:06 [PATCH] arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible Johan Hovold
@ 2023-10-16 8:53 ` Dmitry Baryshkov
2023-10-16 9:04 ` Johan Hovold
2023-12-03 4:54 ` Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-10-16 8:53 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, stable
On Mon, 16 Oct 2023 at 11:07, Johan Hovold <johan+linaro@kernel.org> wrote:
>
> The sc8280xp Display Port PHYs can be used in either DP or eDP mode and
> this is configured using the devicetree compatible string which defaults
> to DP mode in the SoC dtsi.
>
> Override the default compatible string for the CRD eDP PHY node so that
> the eDP settings are used.
>
> Fixes: 4a883a8d80b5 ("arm64: dts: qcom: sc8280xp-crd: Enable EDP")
> Cc: stable@vger.kernel.org # 6.3
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index 772953dc428e..31a2a2d27f4e 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -458,6 +458,8 @@ mdss0_dp3_out: endpoint {
> };
>
> &mdss0_dp3_phy {
> + compatible = "qcom,sc8280xp-edp-phy";
Same question here as the one I've sent for Konrad's patch. Is it the
same PHY type, just being repurposed for eDP or is it a different PHY
type?
> +
> vdda-phy-supply = <&vreg_l6b>;
> vdda-pll-supply = <&vreg_l3b>;
>
> --
> 2.41.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible
2023-10-16 8:53 ` Dmitry Baryshkov
@ 2023-10-16 9:04 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2023-10-16 9:04 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Johan Hovold, Bjorn Andersson, Andy Gross, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel, stable
On Mon, Oct 16, 2023 at 11:53:02AM +0300, Dmitry Baryshkov wrote:
> On Mon, 16 Oct 2023 at 11:07, Johan Hovold <johan+linaro@kernel.org> wrote:
> >
> > The sc8280xp Display Port PHYs can be used in either DP or eDP mode and
> > this is configured using the devicetree compatible string which defaults
> > to DP mode in the SoC dtsi.
> >
> > Override the default compatible string for the CRD eDP PHY node so that
> > the eDP settings are used.
> >
> > Fixes: 4a883a8d80b5 ("arm64: dts: qcom: sc8280xp-crd: Enable EDP")
> > Cc: stable@vger.kernel.org # 6.3
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > index 772953dc428e..31a2a2d27f4e 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > @@ -458,6 +458,8 @@ mdss0_dp3_out: endpoint {
> > };
> >
> > &mdss0_dp3_phy {
> > + compatible = "qcom,sc8280xp-edp-phy";
>
> Same question here as the one I've sent for Konrad's patch. Is it the
> same PHY type, just being repurposed for eDP or is it a different PHY
> type?
Just replied in the other thread:
https://lore.kernel.org/lkml/ZSz7---IW_7Oj2Zr@hovoldconsulting.com/
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible
2023-10-16 8:06 [PATCH] arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible Johan Hovold
2023-10-16 8:53 ` Dmitry Baryshkov
@ 2023-12-03 4:54 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-12-03 4:54 UTC (permalink / raw)
To: Johan Hovold
Cc: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel, stable
On Mon, 16 Oct 2023 10:06:58 +0200, Johan Hovold wrote:
> The sc8280xp Display Port PHYs can be used in either DP or eDP mode and
> this is configured using the devicetree compatible string which defaults
> to DP mode in the SoC dtsi.
>
> Override the default compatible string for the CRD eDP PHY node so that
> the eDP settings are used.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible
commit: 663affdb12b3e26c77d103327cf27de720c8117e
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-03 4:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 8:06 [PATCH] arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible Johan Hovold
2023-10-16 8:53 ` Dmitry Baryshkov
2023-10-16 9:04 ` Johan Hovold
2023-12-03 4:54 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).