From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Paul Gazzillo <paul@pgazz.com>, Matt Ranostay <matt@ranostay.sg>,
Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor
Date: Fri, 27 Oct 2023 14:07:41 +0300 [thread overview]
Message-ID: <ZTuZ/Y2Go/RGOG7U@smile.fi.intel.com> (raw)
In-Reply-To: <20231027074545.6055-3-subhajit.ghosh@tweaklogic.com>
On Fri, Oct 27, 2023 at 06:15:45PM +1030, Subhajit Ghosh wrote:
> Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor with als
> and clear channels with i2c interface. Hardware interrupt configuration is
> optional. It is a low power device with 20 bit resolution and has
> configurable adaptive interrupt mode and interrupt persistence mode.
> The device also features inbuilt hardware gain, multiple integration time
> selection options and sampling frequency selection options.
Please, do not send so often this big patches (~1.5kLoC!), let reviewers a bit
of time, please.
Since I have my message postponed, I finish review on the v1, and I believe
100% of those comments will be applicable here.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-27 11:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 7:45 [PATCH v2 0/2] Support for Avago APDS9306 Ambient Light Sensor Subhajit Ghosh
2023-10-27 7:45 ` [PATCH v2 1/2] dt-bindings: iio: light: Avago APDS9306 Subhajit Ghosh
2023-10-27 8:11 ` Krzysztof Kozlowski
2023-10-27 8:55 ` Subhajit Ghosh
2023-10-27 11:03 ` Krzysztof Kozlowski
2023-10-28 13:29 ` Jonathan Cameron
2023-10-27 7:45 ` [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor Subhajit Ghosh
2023-10-27 8:13 ` Krzysztof Kozlowski
2023-10-27 8:42 ` Subhajit Ghosh
2023-10-27 11:04 ` Krzysztof Kozlowski
2023-10-27 11:42 ` Subhajit Ghosh
2023-10-28 13:36 ` Jonathan Cameron
2023-10-27 11:07 ` Andy Shevchenko [this message]
2023-10-27 11:36 ` Subhajit Ghosh
2023-10-28 6:29 ` kernel test robot
2023-10-28 15:20 ` Jonathan Cameron
2023-10-29 15:51 ` Matti Vaittinen
2023-10-30 10:21 ` Matti Vaittinen
2023-10-31 7:11 ` Matti Vaittinen
2023-10-31 8:20 ` Subhajit Ghosh
2023-10-31 10:38 ` Andy Shevchenko
2023-10-31 11:39 ` Matti Vaittinen
2023-10-31 12:07 ` Matti Vaittinen
2023-10-31 13:42 ` Andy Shevchenko
2023-11-01 6:16 ` Matti Vaittinen
2023-11-02 12:50 ` Andy Shevchenko
2023-10-31 8:38 ` Subhajit Ghosh
2023-11-06 11:13 ` Jonathan Cameron
2023-11-06 12:04 ` Subhajit Ghosh
2023-11-06 12:10 ` Matti Vaittinen
2023-12-04 9:51 ` Jonathan Cameron
2023-11-05 14:22 ` kernel test robot
2023-11-06 10:07 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTuZ/Y2Go/RGOG7U@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@ranostay.sg \
--cc=mazziesaccount@gmail.com \
--cc=paul@pgazz.com \
--cc=robh+dt@kernel.org \
--cc=stefan.windfeldt-prytz@axis.com \
--cc=subhajit.ghosh@tweaklogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).