Re: [PATCH v3 1/6] dt-bindings: PCI: dwc: rockchip: Add mandatory atu reg

Niklas Cassel
2023-10-27T16:14:38Z

Hello Rob,

On Fri, Oct 27, 2023 at 10:58:28AM -0500, Rob Herring wrote:
> On Fri, Oct 27, 2023 at 9:56 AM Niklas Cassel <nks@flawful.org> wrote:
> >
> > From: Niklas Cassel <niklas.cassel@wdc.com>
> >
> > Even though rockchip-dw-pcie.yaml inherits snps,dw-pcie.yaml
> > using:
> >
> > allOf:
> > - $ref: /schemas/pci/snps,dw-pcie.yaml#
> >
> > and snps,dw-pcie.yaml does have the atu reg defined, in order to be
> > able to use this reg, while still making sure 'make CHECK_DTBS=y'
> > pass, we need to add this reg to rockchip-dw-pcie.yaml.
> >
> > All compatible strings (rockchip,rk3568-pcie and rockchip,rk3588-pcie)
> > should have this reg.
> >
> > The regs in the example are updated to actually match pcie3x2 on rk3568.
>
> Breaking compatibility on these platforms is okay because ...?

I don't follow, could you please elaborate?

Kind regards,
Niklas