From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C06973B785 for ; Fri, 10 Nov 2023 20:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FBA1A9; Fri, 10 Nov 2023 12:18:51 -0800 (PST) Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1r1Xxe-0008HJ-0s; Fri, 10 Nov 2023 20:18:38 +0000 Date: Fri, 10 Nov 2023 20:18:33 +0000 From: Daniel Golle To: Krzysztof Kozlowski Cc: AngeloGioacchino Del Regno , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Philipp Zabel , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: watchdog: mediatek,mtk-wdt: add MT7988 watchdog and toprgu Message-ID: References: <708046ae-a821-420c-959a-ab5cb712aa9e@linaro.org> <6576d4a6-31fa-4780-9a8a-5a1d1974836f@linaro.org> <8846adad-9504-4ffd-b9c3-f5e78082d261@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8846adad-9504-4ffd-b9c3-f5e78082d261@linaro.org> On Fri, Nov 10, 2023 at 08:58:57PM +0100, Krzysztof Kozlowski wrote: > I am repeating myself... but I don't know how to put it other way. I did > not ask you to rewrite your driver. I asked to drop the change to > bindings, because it is entirely pointless. > > Drop this change, only this. No need to rewrite drivers, they stay the same. Dropping this change (I'm assuming you are referring to the hunk adding include/dt-bindings/reset/mt7988-resets.h) and also not adding that header file using a seperate commit means that there won't be a header defining the reset names. The result would be having to numerically reference the specific resets in the device tree. This is, of course, possible, but I don't understand what the advantage would be.