From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org,
Paul Elder <paul.elder@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Julien Stephan <jstephan@baylibre.com>,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
rafael@kernel.org
Subject: Re: [PATCH v2 1/1] device property: Add fwnode_name_eq()
Date: Thu, 2 Nov 2023 14:57:10 +0200 [thread overview]
Message-ID: <ZUOcpr01VRWdBL-E@smile.fi.intel.com> (raw)
In-Reply-To: <ZUIhr1Wiy96PMEKx@kekkonen.localdomain>
On Wed, Nov 01, 2023 at 10:00:15AM +0000, Sakari Ailus wrote:
> On Wed, Nov 01, 2023 at 11:50:00AM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 01, 2023 at 09:27:29AM +0200, Sakari Ailus wrote:
...
> > > - Use size_t type for len.
> >
> > Strictly speaking it should be ptrdiff_t according to the code.
>
> It'll be compared to size_t right after. ptrdiff_t is signed and we know we
> have a positive number here so size_t seems like a better choice.
Yeah, this is downsides of C language and typing system.
But diff between pointers returns ptrdiff_t result.
...
> > > + * the comparison to either '\0' or '@' character
> >
> > NUL is a human-readable substitution to less parsable '\0'.
>
> I can send v3 with that but I'll wait a bit if there are more comments.
Why not? You got tags, so I'll give mine with this being addressed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-02 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 7:27 [PATCH v2 1/1] device property: Add fwnode_name_eq() Sakari Ailus
2023-11-01 9:50 ` Andy Shevchenko
2023-11-01 10:00 ` Sakari Ailus
2023-11-02 12:57 ` Andy Shevchenko [this message]
2023-11-02 0:51 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUOcpr01VRWdBL-E@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jstephan@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=paul.elder@ideasonboard.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).