From: Stephan Gerhold <stephan@gerhold.net>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Dang Huynh <danct12@riseup.net>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Robert Marko <robimarko@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 5/8] regulator: qcom_smd: Add PM8937 regulators
Date: Mon, 6 Nov 2023 20:32:06 +0100 [thread overview]
Message-ID: <ZUk_NmR9Hb922ZFF@gerhold.net> (raw)
In-Reply-To: <CAA8EJprRT=thU-7_rfX6Qhk55iC9Hc0d8x46uyt-p4DOHCrrwQ@mail.gmail.com>
On Mon, Nov 06, 2023 at 02:15:12PM +0200, Dmitry Baryshkov wrote:
> On Mon, 6 Nov 2023 at 14:11, Dang Huynh <danct12@riseup.net> wrote:
> >
> > The PM8937 is found on boards with MSM8917, MSM8937, MSM8940 SoCs and
> > APQ variants.
> >
> > It provides 6 SMPS (two are controlled by SPMI) and 23 LDO regulators.
> >
> > Signed-off-by: Dang Huynh <danct12@riseup.net>
>
> I haven't checked LDO / SMPS types.
That's kind of the part where one would most likely make mistakes
though. :D
I checked them based on the log Dang posted on IRC, by cross-referencing
the voltage ranges with the regulator types in the SPMI regulator driver.
Looks good :)
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Thanks,
Stephan
(bootloader) Detected PMIC 0x10019
(bootloader) s1: 1225000 mV, disabled, fast (smps)
(bootloader) s2: 1162500 mV, enabled, fast (smps)
(bootloader) s3: 1412500 mV, enabled, fast (smps)
(bootloader) s4: 2050000 mV, enabled, fast (smps)
(bootloader) s5: 1225000 mV, enabled, fast (ftsmps2p5)
(bootloader) s6: 1225000 mV, enabled, fast (ftsmps2p5)
(bootloader) l1: 1000000 mV, disabled, normal (ult_nldo)
(bootloader) l2: 1250000 mV, enabled, normal (ult_nldo)
(bootloader) l3: 1350000 mV, enabled, idle (ult_nldo)
(bootloader) l4: 1800000 mV, disabled, normal (ult_pldo)
(bootloader) l5: 1800000 mV, enabled, idle (ult_pldo)
(bootloader) l6: 1800000 mV, enabled, normal (ult_pldo)
(bootloader) l7: 1800000 mV, enabled, normal (ult_pldo)
(bootloader) l8: 2900000 mV, enabled, normal (ult_pldo)
(bootloader) l9: 3300000 mV, disabled, normal (ult_pldo)
(bootloader) l10: 2800000 mV, disabled, normal (ult_pldo)
(bootloader) l11: 2950000 mV, enabled, normal (ult_pldo)
(bootloader) l12: 2950000 mV, enabled, normal (ult_pldo)
(bootloader) l13: 3075000 mV, enabled, normal (ult_pldo)
(bootloader) l14: 1800000 mV, disabled, normal (ult_pldo)
(bootloader) l15: 1800000 mV, disabled, normal (ult_pldo)
(bootloader) l16: 1800000 mV, disabled, normal (ult_pldo)
(bootloader) l17: 2850000 mV, enabled, normal (ult_pldo)
(bootloader) l18: 2700000 mV, disabled, normal (ult_pldo)
(bootloader) l19: 1300000 mV, disabled, normal (ult_nldo)
(bootloader) l20: 1740000 mV, disabled (ln_ldo)
(bootloader) l21: 1740000 mV, disabled (ln_ldo)
(bootloader) l22: 2800000 mV, disabled, normal (ult_pldo)
(bootloader) l23: 1300000 mV, disabled, normal (nldo1)
next prev parent reply other threads:[~2023-11-06 19:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 12:08 [PATCH 0/8] Add PM8937 PMIC support Dang Huynh
2023-11-06 12:08 ` [PATCH 1/8] mfd: qcom-spmi-pmic: Add support for PM8937 Dang Huynh
2023-11-06 13:55 ` Caleb Connolly
2023-11-06 12:08 ` [PATCH 2/8] dt-bindings: mfd: qcom-spmi-pmic: Document PM8937 PMIC Dang Huynh
2023-11-06 13:11 ` Krzysztof Kozlowski
2023-11-06 12:08 ` [PATCH 3/8] regulator: qcom_spmi: Add PM8937 SPMI regulator Dang Huynh
2023-11-06 12:35 ` Dmitry Baryshkov
2023-11-06 12:08 ` [PATCH 4/8] dt-bindings: regulator: qcom,spmi-regulator: Document PM8937 PMIC Dang Huynh
2023-11-06 13:12 ` Krzysztof Kozlowski
2023-11-06 12:08 ` [PATCH 5/8] regulator: qcom_smd: Add PM8937 regulators Dang Huynh
2023-11-06 12:15 ` Dmitry Baryshkov
2023-11-06 19:32 ` Stephan Gerhold [this message]
2023-11-06 12:08 ` [PATCH 6/8] dt-bindings: regulator: qcom,smd-rpm-regulator: Document PM8937 IC Dang Huynh
2023-11-06 13:13 ` Krzysztof Kozlowski
2023-11-06 12:08 ` [PATCH 7/8] arm64: dts: qcom: Add PM8937 PMIC Dang Huynh
2023-11-06 12:20 ` Dmitry Baryshkov
2023-11-06 17:21 ` Stephan Gerhold
2023-11-07 21:29 ` Konrad Dybcio
2023-11-06 12:08 ` [PATCH 8/8] soc: qcom: socinfo: Add PM8937 Power IC Dang Huynh
2023-11-07 21:30 ` Konrad Dybcio
2023-11-08 5:38 ` Dang Huynh
2023-11-09 15:22 ` Bjorn Andersson
2023-11-06 12:16 ` [PATCH 0/8] Add PM8937 PMIC support Dmitry Baryshkov
2023-11-13 19:40 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUk_NmR9Hb922ZFF@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danct12@riseup.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).