From: Vinod Koul <vkoul@kernel.org>
To: Rob Herring <robh@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Jai Luthra <j-luthra@ti.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: Drop undocumented examples
Date: Thu, 23 Nov 2023 14:22:33 +0530 [thread overview]
Message-ID: <ZV8S0WAz+NbYUc84@matsya> (raw)
In-Reply-To: <20231122235050.2966280-1-robh@kernel.org>
On 22-11-23, 16:50, Rob Herring wrote:
> The compatibles "ti,omap-sdma" and "ti,dra7-dma-crossbar" aren't documented
> by a schema which causes warnings:
>
> Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma']
> Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar']
So instead now we will have undocumented ti-omap-sdma?
Adding Peter and TI folks as well
> As no one has cared to fix them, just drop them.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/dma/dma-controller.yaml | 15 ---------------
> .../devicetree/bindings/dma/dma-router.yaml | 11 -----------
> 2 files changed, 26 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/dma-controller.yaml b/Documentation/devicetree/bindings/dma/dma-controller.yaml
> index 04d150d4d15d..e6afca558c2d 100644
> --- a/Documentation/devicetree/bindings/dma/dma-controller.yaml
> +++ b/Documentation/devicetree/bindings/dma/dma-controller.yaml
> @@ -19,19 +19,4 @@ properties:
>
> additionalProperties: true
>
> -examples:
> - - |
> - dma: dma-controller@48000000 {
> - compatible = "ti,omap-sdma";
> - reg = <0x48000000 0x1000>;
> - interrupts = <0 12 0x4>,
> - <0 13 0x4>,
> - <0 14 0x4>,
> - <0 15 0x4>;
> - #dma-cells = <1>;
> - dma-channels = <32>;
> - dma-requests = <127>;
> - dma-channel-mask = <0xfffe>;
> - };
> -
> ...
> diff --git a/Documentation/devicetree/bindings/dma/dma-router.yaml b/Documentation/devicetree/bindings/dma/dma-router.yaml
> index 346fe0fa4460..5ad2febc581e 100644
> --- a/Documentation/devicetree/bindings/dma/dma-router.yaml
> +++ b/Documentation/devicetree/bindings/dma/dma-router.yaml
> @@ -40,15 +40,4 @@ required:
>
> additionalProperties: true
>
> -examples:
> - - |
> - sdma_xbar: dma-router@4a002b78 {
> - compatible = "ti,dra7-dma-crossbar";
> - reg = <0x4a002b78 0xfc>;
> - #dma-cells = <1>;
> - dma-requests = <205>;
> - ti,dma-safe-map = <0>;
> - dma-masters = <&sdma>;
> - };
> -
> ...
> --
> 2.42.0
--
~Vinod
next prev parent reply other threads:[~2023-11-23 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 23:50 [PATCH] dt-bindings: dma: Drop undocumented examples Rob Herring
2023-11-23 7:35 ` Krzysztof Kozlowski
2023-11-23 8:52 ` Vinod Koul [this message]
2023-11-23 8:53 ` Krzysztof Kozlowski
2023-12-07 20:59 ` Rob Herring
2023-12-11 6:31 ` Vinod Koul
2023-12-11 15:04 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV8S0WAz+NbYUc84@matsya \
--to=vkoul@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox