From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 067242E83A for ; Tue, 14 Nov 2023 22:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="YLwfwu8f" Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 261E1BE for ; Tue, 14 Nov 2023 14:24:59 -0800 (PST) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-5bf5d6eaf60so65290437b3.2 for ; Tue, 14 Nov 2023 14:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1700000698; x=1700605498; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VZH1moAA0yVg/Bb0Aws1epxcC7ep8j8z+Au9OoiC60Y=; b=YLwfwu8f4r9Why3kj5g+LjIriHAIWAZSK2cqGUVcK/FL1qccdznGhtlV0Mi1ZtMhNG PzEDavVxIdD2i7wac6AxaWnvXvuYDZhBLu0lA8OBrn/ofkPDaF9wynJzXVS8E9COnA4a 1DiIsn8Q1mHdL1PVWRfkLmtL3nMS974daABG8RyoE32AeIls5DnjSIA4XC3le11UFDgO EVAhfRi33dHllU2nvt+/dO5EvSzVn2yYoP4z9Traqp3H6Vzrv6a0WDgsgv+Q76PpYUUB S3tfo5wvatOEnrfNEZvziq5t9JXtN/NTNO4u3S8lxS09iDr5bVaWre/Okw+/1ly16hDh iIFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700000698; x=1700605498; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VZH1moAA0yVg/Bb0Aws1epxcC7ep8j8z+Au9OoiC60Y=; b=i6cm1NPlu81Sx/nsKrBJ0rm0SmmlzehsheirCSjO52QgKCAc0qXL0fwiD7TsAsCu0y YYKPlXqXaFhH9Y0/6jjvZD9q094xG7isTo99vPFJqK+Usgi0VsmDd+YbfRXqoKjGE7YE N03ok1luYQ3yCqBBUrwAujyk1CxOYvuTRQUtjR42yYRCQSBROV2ZPu2fBFH/KIl2Hzg4 Ijq+3ySdairURHPbwzvcozFwx1iVH5r5fByrv6j9RDSZrBwT1GaOmv+vzsQnKuPWDtqB wR+RW7COLA9/9wnFn6appL6OeZrb2HyjXFWnMCKerTaQ2+Kj49XDcinA0nbasDRTwUq1 O8ag== X-Gm-Message-State: AOJu0YxqM/Bf9tH2XLnXfDhyu/lz1uyx55hMjc7LloD6Y9aqb1szpvJY 7aSB22xGu4qKGkI1tq6z8Z82Rw== X-Google-Smtp-Source: AGHT+IEz88PTlxccW21WoEn2f42pE+pucQRcPi0Qyotu8SKV4KH1w7/IOT3aZDt9e1YeaqgPDQ7h+A== X-Received: by 2002:a81:73c2:0:b0:59c:aea:d877 with SMTP id o185-20020a8173c2000000b0059c0aead877mr11208270ywc.40.1700000698319; Tue, 14 Nov 2023 14:24:58 -0800 (PST) Received: from x1 ([12.186.190.2]) by smtp.gmail.com with ESMTPSA id m1-20020ad44d41000000b00670c7fd09cbsm3706qvm.95.2023.11.14.14.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 14:24:58 -0800 (PST) Date: Tue, 14 Nov 2023 17:24:55 -0500 From: Drew Fustini To: Conor Dooley Cc: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jisheng Zhang , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Fu Wei , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v6 6/7] riscv: dts: thead: Enable BeagleV Ahead eMMC and microSD Message-ID: References: <20231114-th1520-mmc-v6-0-3273c661a571@baylibre.com> <20231114-th1520-mmc-v6-6-3273c661a571@baylibre.com> <20231114-subsiding-tipoff-f3c15ef22985@squawk> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231114-subsiding-tipoff-f3c15ef22985@squawk> On Tue, Nov 14, 2023 at 09:24:40PM +0000, Conor Dooley wrote: > On Tue, Nov 14, 2023 at 04:08:00PM -0500, Drew Fustini wrote: > > > +&mmc0 { > > + bus-width = <8>; > > + max-frequency = <198000000>; > > > +&mmc1 { > > + max-frequency = <198000000>; > > + bus-width = <4>; > > If there's another iteration of this patchset, can you use a consistent > ordering for your properties please? Bah, I don't know how I missed that. Thanks for spotting that. I'll fix it if there is another rev. I still need to see if Jisheng's is okay with the most recent changes in the driver patch. Drew