From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BYEyMmMw" Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04E36CB for ; Mon, 20 Nov 2023 08:53:33 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-32d895584f1so3314615f8f.1 for ; Mon, 20 Nov 2023 08:53:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700499211; x=1701104011; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0+gDpEFBGCZPC35kFuu8atg4ddHQhZ0gqgHVoGyLF54=; b=BYEyMmMwjSA2hXJjTOUKF1oYgXJzduN81Beekvwey654UpjT/NRoqkqJ0Lj+i2scby ELbrX0o1UvoY6Ul5T5eeARzDn7Sk2H/SXogz4+hjf/SVDyU1XVm7paIwcJuHQd8iJm6n 0x2h+vOPT5j9K/xpLtHhG/oyxNYsIrOQZh0EKnOVaXy7Qgr1btC6MloTSGW6sdFr7UjS hMDPVd/8bHOgTlUNL3RCa4fZdV3Tk/heZd9CP9whnsuLIm4fKfelQP4MhYHNyhZJ5yQ9 66GyXYbVg5g5UldmrpQfOdsSnEPRb6H9jWDzD1jQH8NmNE16u007lzQXZm7K9mshv49s 5CeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700499211; x=1701104011; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0+gDpEFBGCZPC35kFuu8atg4ddHQhZ0gqgHVoGyLF54=; b=tj97nlmipgtNymK7p7DxpPV1K7BZb/BQMeSqJ4X16g0GtzKOxaLq5y1Wn/3YbgCePs IDKbdouSIYNH2YbvFQrdARahLQsw2a0XlDYJJjkmVJdYQBNuQdZAp/pRsGyeoWqb+nXU afUCme0ifn0i0HubWJNYtoUmr8Clxvqn7BUphEP+DL118cAdwbYiRfj6dPzHJTjj5yZB z1fI3GHfDXHZanluCSiCfjy4/4a1p+onhi+xp2o/jz100y1ikM+IweQhPtiu5Nb7gboo 8zakv+KmmBjEV+hHlA+8XDFzZLKY6fPML85BdOpCJQN0iL3fTvGSlpwM+7bbNnM3cCuP ucJg== X-Gm-Message-State: AOJu0YzEKj9rlSXO6QfwU0rM8Nvy2qc7sjNH3qz2k6mtcZFAYKTN6/e6 giHJsXuHoLncooP/IvWtBlk3Ow== X-Google-Smtp-Source: AGHT+IEvxCLLUYVrYXIWophHdZIhi/VeSga73kO+5zNIwblLLdJFqZU8ZxKMQCA+n16sBchlEO7bhg== X-Received: by 2002:a5d:5f90:0:b0:32d:967d:1baf with SMTP id dr16-20020a5d5f90000000b0032d967d1bafmr5701802wrb.1.1700499211433; Mon, 20 Nov 2023 08:53:31 -0800 (PST) Received: from linaro.org ([86.123.99.122]) by smtp.gmail.com with ESMTPSA id b8-20020a5d45c8000000b003142e438e8csm11707602wrs.26.2023.11.20.08.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 08:53:31 -0800 (PST) Date: Mon, 20 Nov 2023 18:53:29 +0200 From: Abel Vesa To: Johan Hovold Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] arm64: dts: qcom: sm8550: fix USB wakeup interrupt types Message-ID: References: <20231120164331.8116-1-johan+linaro@kernel.org> <20231120164331.8116-12-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120164331.8116-12-johan+linaro@kernel.org> On 23-11-20 17:43:31, Johan Hovold wrote: > The DP/DM wakeup interrupts are edge triggered and which edge to trigger > on depends on use-case and whether a Low speed or Full/High speed device > is connected. > > Note that only triggering on rising edges can be used to detect resume > events but not disconnect events. > > Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes") > Cc: Abel Vesa > Signed-off-by: Johan Hovold Reviewed-by: Abel Vesa > --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index 7b9ddde0b2c9..9b5b098bb7e8 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -2923,8 +2923,8 @@ usb_1: usb@a6f8800 { > > interrupts-extended = <&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>, > <&pdc 17 IRQ_TYPE_LEVEL_HIGH>, > - <&pdc 15 IRQ_TYPE_EDGE_RISING>, > - <&pdc 14 IRQ_TYPE_EDGE_RISING>; > + <&pdc 15 IRQ_TYPE_EDGE_BOTH>, > + <&pdc 14 IRQ_TYPE_EDGE_BOTH>; > interrupt-names = "hs_phy_irq", > "ss_phy_irq", > "dm_hs_phy_irq", > -- > 2.41.0 >