* [PATCH 1/3] arm64: dts: qcom: qrb5165-rb5: add an alias for uart6 @ 2023-12-05 11:23 Bartosz Golaszewski 2023-12-05 11:23 ` [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO Bartosz Golaszewski 2023-12-05 11:23 ` [PATCH 3/3] arm64: dts: qcom: qrb5165-rb5: add the Bluetooth node Bartosz Golaszewski 0 siblings, 2 replies; 6+ messages in thread From: Bartosz Golaszewski @ 2023-12-05 11:23 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Alex Elder, Srini Kandagatla Cc: linux-arm-msm, linux-kernel, devicetree, Bartosz Golaszewski From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Alias uart6 to serial1 for qrb5165-rb5. This is the high-speed port used by Bluetooth. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index c8cd40a462a3..ce6ae0771d34 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -23,6 +23,7 @@ / { aliases { serial0 = &uart12; + serial1 = &uart6; sdhc2 = &sdhc_2; }; -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO 2023-12-05 11:23 [PATCH 1/3] arm64: dts: qcom: qrb5165-rb5: add an alias for uart6 Bartosz Golaszewski @ 2023-12-05 11:23 ` Bartosz Golaszewski 2023-12-05 11:42 ` Johan Hovold ` (2 more replies) 2023-12-05 11:23 ` [PATCH 3/3] arm64: dts: qcom: qrb5165-rb5: add the Bluetooth node Bartosz Golaszewski 1 sibling, 3 replies; 6+ messages in thread From: Bartosz Golaszewski @ 2023-12-05 11:23 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Alex Elder, Srini Kandagatla Cc: linux-arm-msm, linux-kernel, devicetree, Bartosz Golaszewski From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Set up the pin function for the Bluetooth enable GPIO. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index ce6ae0771d34..ead0c45ba60c 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -1264,6 +1264,17 @@ &tlmm { "HST_WLAN_UART_TX", "HST_WLAN_UART_RX"; + bt_en_state: bt-default-state { + bt-en { + pins = "gpio21"; + function = "gpio"; + + drive-strength = <16>; + output-low; + bias-pull-up; + }; + }; + lt9611_irq_pin: lt9611-irq-state { pins = "gpio63"; function = "gpio"; -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO 2023-12-05 11:23 ` [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO Bartosz Golaszewski @ 2023-12-05 11:42 ` Johan Hovold 2023-12-05 11:52 ` Krzysztof Kozlowski 2023-12-05 12:07 ` Konrad Dybcio 2 siblings, 0 replies; 6+ messages in thread From: Johan Hovold @ 2023-12-05 11:42 UTC (permalink / raw) To: Bartosz Golaszewski Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Alex Elder, Srini Kandagatla, linux-arm-msm, linux-kernel, devicetree, Bartosz Golaszewski On Tue, Dec 05, 2023 at 12:23:10PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Set up the pin function for the Bluetooth enable GPIO. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index ce6ae0771d34..ead0c45ba60c 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -1264,6 +1264,17 @@ &tlmm { > "HST_WLAN_UART_TX", > "HST_WLAN_UART_RX"; > > + bt_en_state: bt-default-state { > + bt-en { > + pins = "gpio21"; > + function = "gpio"; > + > + drive-strength = <16>; > + output-low; > + bias-pull-up; > + }; > + }; > + > lt9611_irq_pin: lt9611-irq-state { > pins = "gpio63"; > function = "gpio"; This makes no sense as a separate patch and should be squashed with the final patch enabling bluetooth. Same for the first patch. Johan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO 2023-12-05 11:23 ` [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO Bartosz Golaszewski 2023-12-05 11:42 ` Johan Hovold @ 2023-12-05 11:52 ` Krzysztof Kozlowski 2023-12-05 12:07 ` Konrad Dybcio 2 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2023-12-05 11:52 UTC (permalink / raw) To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Alex Elder, Srini Kandagatla Cc: linux-arm-msm, linux-kernel, devicetree, Bartosz Golaszewski On 05/12/2023 12:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Set up the pin function for the Bluetooth enable GPIO. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index ce6ae0771d34..ead0c45ba60c 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -1264,6 +1264,17 @@ &tlmm { > "HST_WLAN_UART_TX", > "HST_WLAN_UART_RX"; > > + bt_en_state: bt-default-state { > + bt-en { This looks like tlmm, so you miss here suffix. It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO 2023-12-05 11:23 ` [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO Bartosz Golaszewski 2023-12-05 11:42 ` Johan Hovold 2023-12-05 11:52 ` Krzysztof Kozlowski @ 2023-12-05 12:07 ` Konrad Dybcio 2 siblings, 0 replies; 6+ messages in thread From: Konrad Dybcio @ 2023-12-05 12:07 UTC (permalink / raw) To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Krzysztof Kozlowski, Alex Elder, Srini Kandagatla Cc: linux-arm-msm, linux-kernel, devicetree, Bartosz Golaszewski On 12/5/23 12:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Set up the pin function for the Bluetooth enable GPIO. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index ce6ae0771d34..ead0c45ba60c 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -1264,6 +1264,17 @@ &tlmm { > "HST_WLAN_UART_TX", > "HST_WLAN_UART_RX"; > > + bt_en_state: bt-default-state { > + bt-en { > + pins = "gpio21"; If it's the only GPIO expected to be here, you may drop the extra bt-en level, like the entry below Konrad ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: qrb5165-rb5: add the Bluetooth node 2023-12-05 11:23 [PATCH 1/3] arm64: dts: qcom: qrb5165-rb5: add an alias for uart6 Bartosz Golaszewski 2023-12-05 11:23 ` [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO Bartosz Golaszewski @ 2023-12-05 11:23 ` Bartosz Golaszewski 1 sibling, 0 replies; 6+ messages in thread From: Bartosz Golaszewski @ 2023-12-05 11:23 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Alex Elder, Srini Kandagatla Cc: linux-arm-msm, linux-kernel, devicetree, Bartosz Golaszewski From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Add the Bluetooth node for RB5. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index ead0c45ba60c..fbdf8fdb532c 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -1308,6 +1308,26 @@ sdc2_card_det_n: sd-card-det-n-state { }; }; +&uart6 { + status = "okay"; + + bluetooth { + compatible = "qcom,qca6390-bt"; + + pinctrl-names = "default"; + pinctrl-0 = <&bt_en_state>; + + enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>; + + vddio-supply = <&vreg_s4a_1p8>; + vddpmu-supply = <&vreg_s2f_0p95>; + vddaon-supply = <&vreg_s6a_0p95>; + vddrfa1-supply = <&vreg_s2f_0p95>; + vddrfa2-supply = <&vreg_s8c_1p3>; + vddrfa3-supply = <&vreg_s5a_1p9>; + }; +}; + &uart12 { status = "okay"; }; -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-05 12:07 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-12-05 11:23 [PATCH 1/3] arm64: dts: qcom: qrb5165-rb5: add an alias for uart6 Bartosz Golaszewski 2023-12-05 11:23 ` [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO Bartosz Golaszewski 2023-12-05 11:42 ` Johan Hovold 2023-12-05 11:52 ` Krzysztof Kozlowski 2023-12-05 12:07 ` Konrad Dybcio 2023-12-05 11:23 ` [PATCH 3/3] arm64: dts: qcom: qrb5165-rb5: add the Bluetooth node Bartosz Golaszewski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox