From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Luo Jie <quic_luoj@quicinc.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
hkallweit1@gmail.com, corbet@lwn.net, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 1/6] net: phy: introduce core support for phy-mode = "10g-qxgmii"
Date: Mon, 27 Nov 2023 08:43:54 +0000 [thread overview]
Message-ID: <ZWRWylzfCLu2XXHy@shell.armlinux.org.uk> (raw)
In-Reply-To: <f97fd2f0-3e39-4de0-8b1c-f333a0f56a7f@lunn.ch>
On Sun, Nov 26, 2023 at 06:20:16PM +0100, Andrew Lunn wrote:
> On Sun, Nov 26, 2023 at 02:07:27PM +0800, Luo Jie wrote:
> > switch (interface) {
> > case PHY_INTERFACE_MODE_USXGMII:
> > - caps |= MAC_10000FD | MAC_5000FD | MAC_2500FD;
> > + caps |= MAC_10000FD | MAC_5000FD;
> > + fallthrough;
>
> This change seems to refer to the second paragraph, where as the rest
> of the code is about the first. Or does splitting this cause a bisect
> problem?
I'm not sure what you're referring to here, and by over-trimming the
context, this probably gives an insight into a misunderstanding.
This hunk (and the next) does _not_ change what USXGMII ends up with.
It moves MAC_2500FD to be under the 10G_QXGMII case from the USXGMII
case, and we will _fallthrough_ from the USXGMII case into thte
10G_QXGMII case. So, USXGMII still ends up with MAC_2500FD.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-11-27 8:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 6:07 [PATCH v6 0/6] add qca8084 ethernet phy driver Luo Jie
2023-11-26 6:07 ` [PATCH v6 1/6] net: phy: introduce core support for phy-mode = "10g-qxgmii" Luo Jie
2023-11-26 17:20 ` Andrew Lunn
2023-11-27 6:12 ` Jie Luo
2023-11-27 8:43 ` Russell King (Oracle) [this message]
2023-11-26 6:07 ` [PATCH v6 2/6] dt-bindings: net: ethernet-controller: add 10g-qxgmii mode Luo Jie
2023-11-26 17:20 ` Andrew Lunn
2023-11-26 6:07 ` [PATCH v6 3/6] net: phy: at803x: add QCA8084 ethernet phy support Luo Jie
2023-11-26 17:31 ` Andrew Lunn
2023-11-27 6:21 ` Jie Luo
2023-11-27 13:22 ` Andrew Lunn
2023-11-28 7:16 ` Jie Luo
2023-11-28 9:00 ` Russell King (Oracle)
2023-11-28 9:50 ` Jie Luo
2023-11-28 10:35 ` Russell King (Oracle)
2023-11-29 10:34 ` Jie Luo
2023-11-29 12:04 ` Vladimir Oltean
2023-12-01 8:05 ` Jie Luo
2023-11-26 6:07 ` [PATCH v6 4/6] net: phy: at803x: add the function phydev_id_is_qca808x Luo Jie
2023-11-26 6:07 ` [PATCH v6 5/6] net: phy: at803x: Add qca8084_config_init function Luo Jie
2023-11-26 6:07 ` [PATCH v6 6/6] net: phy: qca8084: add qca8084_link_change_notify Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWRWylzfCLu2XXHy@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_luoj@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).