From: Petre Rodan <petre.rodan@subdimension.ro>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: pressure: add honeywell,hsc030
Date: Mon, 27 Nov 2023 14:49:02 +0200 [thread overview]
Message-ID: <ZWSQPrExmcT5kPit@sunspire> (raw)
In-Reply-To: <8641e35a-d481-4c27-b450-9ee72ae769b5@linaro.org>
On Mon, Nov 27, 2023 at 09:06:54AM +0100, Krzysztof Kozlowski wrote:
> On 26/11/2023 11:14, Petre Rodan wrote:
> > + honeywell,pmin-pascal:
> > + description: |
> > + Minimum pressure value the sensor can measure in pascal.
> > + To be specified only if honeywell,pressure-triplet is set to "NA".
> > + $ref: /schemas/types.yaml#/definitions/int32
> > +
> > + honeywell,pmax-pascal:
> > + description: |
> > + Maximum pressure value the sensor can measure in pascal.
> > + To be specified only if honeywell,pressure-triplet is set to "NA".
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> Sent a pull request:
> https://github.com/devicetree-org/dt-schema/pull/118
> Once it get merged, both $ref could be dropped.
thank your for the PR.
in patternProperties, please also add the int32 type for pascal.
your patch seems to cover kilopascal only.
cheers,
peter
>
> Best regards,
> Krzysztof
>
--
petre rodan
next prev parent reply other threads:[~2023-11-27 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 10:14 [PATCH v3 1/2] dt-bindings: iio: pressure: add honeywell,hsc030 Petre Rodan
2023-11-27 8:06 ` Krzysztof Kozlowski
2023-11-27 12:49 ` Petre Rodan [this message]
2023-11-27 13:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWSQPrExmcT5kPit@sunspire \
--to=petre.rodan@subdimension.ro \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).