From: Petre Rodan <petre.rodan@subdimension.ro>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: iio: pressure: add honeywell,hsc030
Date: Wed, 29 Nov 2023 10:44:38 +0200 [thread overview]
Message-ID: <ZWb59iEftxX6mQdJ@sunspire> (raw)
In-Reply-To: <adf1e932-a201-475e-a562-4e35954159ee@linaro.org>
hi,
On Wed, Nov 29, 2023 at 09:04:17AM +0100, Krzysztof Kozlowski wrote:
> On 29/11/2023 08:04, Petre Rodan wrote:
> > Adds binding for digital Honeywell TruStability HSC and SSC series
> > pressure and temperature sensors.
> > Communication is one way. The sensor only requires 4 bytes worth of
> > clock pulses on both i2c and spi in order to push the data out.
> > The i2c address is hardcoded and depends on the part number.
> > There is no additional GPIO control.
>
> Your threading is broken (not existing) since v4, making it difficult to
> apply the patchset. Please fix it when sending v6.
I'm confused.
you mean the lack of 'In-Reply-To' and 'References' headers in the emails
`git send-email` is generating?
I've added them for v2, but was told that was a mistake [1]
[1] https://lore.kernel.org/lkml/20231125191915.7f1f2dc4@jic23-huawei/
I'm probably misunderstanding something.
also, I hope v5 is flawless enough.
best regards,
peter
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
--
petre rodan
next prev parent reply other threads:[~2023-11-29 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 7:04 [PATCH v5 1/2] dt-bindings: iio: pressure: add honeywell,hsc030 Petre Rodan
2023-11-29 8:04 ` Krzysztof Kozlowski
2023-11-29 8:44 ` Petre Rodan [this message]
2023-11-29 8:47 ` Krzysztof Kozlowski
2023-11-29 14:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWb59iEftxX6mQdJ@sunspire \
--to=petre.rodan@subdimension.ro \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).