Devicetree
 help / color / mirror / Atom feed
From: Tommaso Merciai <tomm.merciai@gmail.com>
To: Paul Elder <paul.elder@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com,
	umang.jain@ideasonboard.com
Subject: Re: [PATCH 0/2] arm64: dts: imx8mp: Add support for the ISPs
Date: Wed, 29 Nov 2023 12:16:56 +0100	[thread overview]
Message-ID: <ZWcdqKHWOPevTNgd@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation> (raw)
In-Reply-To: <20231129093113.255161-1-paul.elder@ideasonboard.com>

Hi Paul, Laurent,

On Wed, Nov 29, 2023 at 06:31:11PM +0900, Paul Elder wrote:
> This patch series adds support to the i.MX8MP device tree for the ISPs.
> 
> Laurent Pinchart (1):
>   arm64: dts: imx8mp: Add overlays for ISP instances
> 
> Paul Elder (1):
>   arm64: dts: imx8mp: Add DT nodes for the two ISPs

Tested also on my side with the following setup:

imx8mp-evk + ov5640
imx8mp-evk + alvium-1500c-500

Below some logs:

imx8mp-evk + ov5640
----------------------------------------------------------------------------------------------------------------
Media device information
--------------------
driver          rkisp1
model           rkisp1
serial
bus info        platform:rkisp1
hw revision     0xe
driver version  6.7.0

Device topology
- entity 1: rkisp1_isp (4 pads, 4 links)
			type V4L2 subdev subtype Unknown flags 0
			device node name /dev/v4l-subdev0
		pad0: Sink
				[fmt:SRGGB10_1X10/800x600 field:none colorspace:raw xfer:none ycbcr:601 quantization:full-range
				 crop.bounds:(0,0)/800x600
				 crop:(0,0)/800x600]
				<- "csis-32e40000.csi":1 [ENABLED]
		pad1: Sink
				[fmt:unknown/0x0 field:none]
				<- "rkisp1_params":0 [ENABLED,IMMUTABLE]
		pad2: Source
				[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range
				 crop.bounds:(0,0)/800x600
				 crop:(0,0)/800x600]
				-> "rkisp1_resizer_mainpath":0 [ENABLED]
		pad3: Source
				[fmt:unknown/0x0 field:none]
				-> "rkisp1_stats":0 [ENABLED,IMMUTABLE]

- entity 6: rkisp1_resizer_mainpath (2 pads, 2 links)
			type V4L2 subdev subtype Unknown flags 0
			device node name /dev/v4l-subdev1
		pad0: Sink
				[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range
				 crop.bounds:(0,0)/800x600
				 crop:(0,0)/800x600]
				<- "rkisp1_isp":2 [ENABLED]
		pad1: Source
				[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range]
				-> "rkisp1_mainpath":0 [ENABLED,IMMUTABLE]

- entity 9: rkisp1_mainpath (1 pad, 1 link)
			type Node subtype V4L flags 0
			device node name /dev/video0
		pad0: Sink
				<- "rkisp1_resizer_mainpath":1 [ENABLED,IMMUTABLE]

- entity 13: rkisp1_stats (1 pad, 1 link)
			 type Node subtype V4L flags 0
			 device node name /dev/video1
		pad0: Sink
				<- "rkisp1_isp":3 [ENABLED,IMMUTABLE]

- entity 17: rkisp1_params (1 pad, 1 link)
			 type Node subtype V4L flags 0
			 device node name /dev/video2
		pad0: Source
				-> "rkisp1_isp":1 [ENABLED,IMMUTABLE]

- entity 29: csis-32e40000.csi (2 pads, 2 links)
			 type V4L2 subdev subtype Unknown flags 0
			 device node name /dev/v4l-subdev2
		pad0: Sink
				[fmt:UYVY8_1X16/640x480 field:none colorspace:smpte170m xfer:709 ycbcr:601 quantization:lim-range]
				<- "ov5640 1-003c":0 []
		pad1: Source
				[fmt:UYVY8_1X16/640x480 field:none colorspace:smpte170m xfer:709 ycbcr:601 quantization:lim-range]
				-> "rkisp1_isp":0 [ENABLED]

- entity 34: ov5640 1-003c (1 pad, 1 link)
			 type V4L2 subdev subtype Sensor flags 0
			 device node name /dev/v4l-subdev3
		pad0: Source
				[fmt:UYVY8_1X16/640x480@1/30 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:full-range
				 crop.bounds:(0,0)/2624x1964
				 crop:(16,14)/2592x1944]
				-> "csis-32e40000.csi":0 []

root@imx8mp-lpddr4-evk:~#
root@imx8mp-lpddr4-evk:~# uname -a
Linux imx8mp-lpddr4-evk 6.7.0-rc2-gff66adbac1c2 #277 SMP PREEMPT Wed Nov 29 11:40:48 CET 2023 aarch64 GNU/Linux
----------------------------------------------------------------------------------------------------------------

imx8mp-evk + alvium 1500c-500:
----------------------------------------------------------------------------------------------------------------

Media device information
--------------------
driver          rkisp1
model           rkisp1
serial
bus info        platform:rkisp1
hw revision     0xe
driver version  6.7.0

Device topology
- entity 1: rkisp1_isp (4 pads, 4 links)
			type V4L2 subdev subtype Unknown flags 0
			device node name /dev/v4l-subdev0
		pad0: Sink
				[fmt:SRGGB10_1X10/800x600 field:none colorspace:raw xfer:none ycbcr:601 quantization:full-range
				 crop.bounds:(0,0)/800x600
				 crop:(0,0)/800x600]
				<- "csis-32e40000.csi":1 [ENABLED]
		pad1: Sink
				[fmt:unknown/0x0 field:none]
				<- "rkisp1_params":0 [ENABLED,IMMUTABLE]
		pad2: Source
				[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range
				 crop.bounds:(0,0)/800x600
				 crop:(0,0)/800x600]
				-> "rkisp1_resizer_mainpath":0 [ENABLED]
		pad3: Source
				[fmt:unknown/0x0 field:none]
				-> "rkisp1_stats":0 [ENABLED,IMMUTABLE]

- entity 6: rkisp1_resizer_mainpath (2 pads, 2 links)
			type V4L2 subdev subtype Unknown flags 0
			device node name /dev/v4l-subdev1
		pad0: Sink
				[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range
				 crop.bounds:(0,0)/800x600
				 crop:(0,0)/800x600]
				<- "rkisp1_isp":2 [ENABLED]
		pad1: Source
				[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range]
				-> "rkisp1_mainpath":0 [ENABLED,IMMUTABLE]

- entity 9: rkisp1_mainpath (1 pad, 1 link)
			type Node subtype V4L flags 0
			device node name /dev/video0
		pad0: Sink
				<- "rkisp1_resizer_mainpath":1 [ENABLED,IMMUTABLE]

- entity 13: rkisp1_stats (1 pad, 1 link)
			 type Node subtype V4L flags 0
			 device node name /dev/video1
		pad0: Sink
				<- "rkisp1_isp":3 [ENABLED,IMMUTABLE]

- entity 17: rkisp1_params (1 pad, 1 link)
			 type Node subtype V4L flags 0
			 device node name /dev/video2
		pad0: Source
				-> "rkisp1_isp":1 [ENABLED,IMMUTABLE]

- entity 29: csis-32e40000.csi (2 pads, 2 links)
			 type V4L2 subdev subtype Unknown flags 0
			 device node name /dev/v4l-subdev2
		pad0: Sink
				[fmt:UYVY8_1X16/640x480 field:none colorspace:smpte170m xfer:709 ycbcr:601 quantization:lim-range]
				<- "alvium-csi2 1-003c":0 []
		pad1: Source
				[fmt:UYVY8_1X16/640x480 field:none colorspace:smpte170m xfer:709 ycbcr:601 quantization:lim-range]
				-> "rkisp1_isp":0 [ENABLED]

- entity 34: alvium-csi2 1-003c (1 pad, 1 link)
			 type V4L2 subdev subtype Sensor flags 0
			 device node name /dev/v4l-subdev3
		pad0: Source
				[fmt:UYVY8_1X16/640x480@1/10 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:full-range
				 crop.bounds:(0,0)/2592x1944
				 crop:(0,0)/640x480]
				-> "csis-32e40000.csi":0 []

root@imx8mp-lpddr4-evk:~# uname -a
Linux imx8mp-lpddr4-evk 6.7.0-rc2-gff66adbac1c2 #277 SMP PREEMPT Wed Nov 29 11:40:48 CET 2023 aarch64 GNU/Linux


Hope this help.

Thanks & Regards,
Tommaso

> 
>  arch/arm64/boot/dts/freescale/Makefile        |  2 +
>  .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++
>  .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi     | 50 +++++++++++++++++++
>  4 files changed, 124 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso
> 
> -- 
> 2.39.2
> 
> 

      parent reply	other threads:[~2023-11-29 11:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29  9:31 [PATCH 0/2] arm64: dts: imx8mp: Add support for the ISPs Paul Elder
2023-11-29  9:31 ` [PATCH 1/2] arm64: dts: imx8mp: Add DT nodes for the two ISPs Paul Elder
2023-11-29 10:17   ` Alexander Stein
2023-11-29 11:59   ` Fabio Estevam
2023-11-29 13:49     ` Adam Ford
2023-11-29 14:26       ` Fabio Estevam
2023-11-29 14:44       ` Laurent Pinchart
2024-03-20 12:35   ` Adam Ford
2024-03-25 15:14     ` Laurent Pinchart
2024-03-25 15:17       ` Adam Ford
2023-11-29  9:31 ` [PATCH 2/2] arm64: dts: imx8mp: Add overlays for ISP instances Paul Elder
2023-11-29 10:20   ` Alexander Stein
2023-11-29 15:16     ` Laurent Pinchart
2023-11-30  9:51       ` Alexander Stein
2023-11-30 13:48         ` Adam Ford
2023-11-30 14:02           ` Kieran Bingham
2023-11-30 14:09             ` Adam Ford
2023-11-30 14:22             ` Alexander Stein
2023-11-30 14:20         ` Laurent Pinchart
2023-11-30 15:34           ` Alexander Stein
2023-11-30 15:54             ` Laurent Pinchart
2023-11-29 11:16 ` Tommaso Merciai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZWcdqKHWOPevTNgd@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation \
    --to=tomm.merciai@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=paul.elder@ideasonboard.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=umang.jain@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox