From: Johan Hovold <johan@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Lee Jones <lee@kernel.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: fix example regulator node
Date: Fri, 1 Dec 2023 17:48:41 +0100 [thread overview]
Message-ID: <ZWoOaRLZGXMhwC_r@hovoldconsulting.com> (raw)
In-Reply-To: <b2400218-12d6-4d51-ab42-78412f616d88@linaro.org>
On Fri, Dec 01, 2023 at 03:42:38PM +0100, Krzysztof Kozlowski wrote:
> On 01/12/2023 15:40, Rob Herring wrote:
> > On Thu, Nov 30, 2023 at 06:25:45PM +0100, Johan Hovold wrote:
> >> The example regulator child nodes do not have unit addresses so drop the
> >> incorrect '#address-cells' and '#size-cells' properties from the parent
> >> node.
> >> regulators {
> >> - #address-cells = <1>;
> >> - #size-cells = <0>;
> >> -
> >
> > It's the right fix, but I have to wonder why these are not schema
> > errors? Seems like something in the schemas needs fixing.
>
> Good point. The fix is just not sufficient. This binding explicitly
> allow it, so it should be removed there as well.
Ah, I missed that. Now fixed up in v2.
Johan
next prev parent reply other threads:[~2023-12-01 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 17:25 [PATCH 0/4] dt-bindings: mfd: fix up PMIC examples Johan Hovold
2023-11-30 17:25 ` [PATCH 1/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: fix up binding reference Johan Hovold
2023-12-01 8:36 ` Krzysztof Kozlowski
2023-11-30 17:25 ` [PATCH 2/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: fix example regulator node Johan Hovold
2023-12-01 8:36 ` Krzysztof Kozlowski
2023-12-01 14:40 ` Rob Herring
2023-12-01 14:42 ` Krzysztof Kozlowski
2023-12-01 16:48 ` Johan Hovold [this message]
2023-11-30 17:25 ` [PATCH 3/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: clean up example Johan Hovold
2023-12-01 8:36 ` Krzysztof Kozlowski
2023-11-30 17:25 ` [PATCH 4/4] dt-bindings: mfd: pm8008: fix example node names Johan Hovold
2023-12-01 8:35 ` Krzysztof Kozlowski
2023-12-01 9:37 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWoOaRLZGXMhwC_r@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox