From: Johan Hovold <johan@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Krishna Chaitanya Chundru <quic_krichai@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_vbadigan@quicinc.com, quic_ramkri@quicinc.com,
quic_nitegupt@quicinc.com, quic_skananth@quicinc.com,
quic_vpernami@quicinc.com, quic_parass@quicinc.com
Subject: Re: [PATCH v3 1/3] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property
Date: Thu, 7 Dec 2023 14:05:12 +0100 [thread overview]
Message-ID: <ZXHDCNosx8PCUzao@hovoldconsulting.com> (raw)
In-Reply-To: <20231207101252.GJ2932@thinkpad>
On Thu, Dec 07, 2023 at 03:42:52PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Dec 07, 2023 at 10:51:09AM +0100, Johan Hovold wrote:
> > On Wed, Dec 06, 2023 at 06:40:09PM +0530, Manivannan Sadhasivam wrote:
> >
> > > OK. How about, "qcom,broken-refclk"? This reflects the fact that the default
> > > refclk operation is broken on this platform, so the OS should be prepared for
> > > it (by keeping it always on).
> >
> > Shouldn't that be
> >
> > qcom,broken-clkreq
> >
> > since its the CLKREQ# signal used to request REFCLK that is broken, not
> > the REFCLK itself?
> >
>
> Darn... You are right. I got carried away by the initial property name. Thanks
> for spotting!
Thinking some more on this after hitting send: It may still be wrong
with a 'broken-clkreq' property in the PHY instead of in the controller
(or endpoint).
Could there not be other ways to handle a broken clkreq signal so that
this really should be a decision made by the OS, for example, to disable
L1 substates and clock PM?
Simply leaving the refclk always on in the PHY seems like a bit of a
hack and I'm not even sure that can be considered correct.
Having a property that maps directly to that behaviour has rightly been
rejected, but it seems that simply renaming the flag but keeping it in
the PHY may still not be the right thing to do here.
Johan
next prev parent reply other threads:[~2023-12-07 13:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 12:13 [PATCH v3 0/3] phy: qcom-qmp-pcie: Add support to keep refclk always on Krishna chaitanya chundru
2023-11-27 12:13 ` [PATCH v3 1/3] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property Krishna chaitanya chundru
2023-11-28 8:56 ` Krzysztof Kozlowski
2023-11-28 9:19 ` Krishna Chaitanya Chundru
2023-12-01 6:07 ` Manivannan Sadhasivam
2023-12-01 8:01 ` Krzysztof Kozlowski
2023-12-01 11:10 ` Manivannan Sadhasivam
2023-12-01 12:10 ` Krzysztof Kozlowski
2023-12-01 12:30 ` Manivannan Sadhasivam
2023-12-01 13:25 ` Krzysztof Kozlowski
2023-12-01 21:29 ` Konrad Dybcio
2023-12-06 13:07 ` Manivannan Sadhasivam
2023-12-07 10:53 ` Konrad Dybcio
2023-12-06 13:10 ` Manivannan Sadhasivam
2023-12-06 17:50 ` Krzysztof Kozlowski
2023-12-07 9:51 ` Johan Hovold
2023-12-07 10:12 ` Manivannan Sadhasivam
2023-12-07 13:05 ` Johan Hovold [this message]
2023-12-07 13:20 ` Manivannan Sadhasivam
2023-12-07 13:36 ` Johan Hovold
2023-12-11 12:32 ` Manivannan Sadhasivam
2023-11-27 12:13 ` [PATCH v3 2/3] phy: qcom-qmp-pcie: Add endpoint refclk control register offset Krishna chaitanya chundru
2023-11-27 12:13 ` [PATCH v3 3/3] phy: qcom-qmp-pcie: Add support for keeping refclk always on Krishna chaitanya chundru
2023-12-01 6:09 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXHDCNosx8PCUzao@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_parass@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=quic_vpernami@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).