devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant
@ 2023-11-13  0:51 Wolfram Sang
  2023-11-13  0:51 ` [PATCH v5 2/3] dt-bindings: gnss: u-blox: add "reset-gpios" binding Wolfram Sang
  2023-12-12  3:30 ` [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant Wolfram Sang
  0 siblings, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2023-11-13  0:51 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Wolfram Sang, devicetree, Johan Hovold, linux-kernel

The Renesas KingFisher board includes a U-Blox Neo-M8 chip with its
reset pin wired to a GPIO. To support that, we need "reset-gpio" support
(patches 2+3). But first, simplify regulator handling with a new helper
(patch 1).

Changes since v4:

* don't touch reset during open/close. Only deassert it during probe.
  [patch 3]


Wolfram Sang (3):
  gnss: ubx: use new helper to remove open coded regulator handling
  dt-bindings: gnss: u-blox: add "reset-gpios" binding
  gnss: ubx: add support for the reset gpio

 .../bindings/gnss/u-blox,neo-6m.yaml          |  5 +++
 drivers/gnss/ubx.c                            | 31 +++++++------------
 2 files changed, 16 insertions(+), 20 deletions(-)

-- 
2.35.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v5 2/3] dt-bindings: gnss: u-blox: add "reset-gpios" binding
  2023-11-13  0:51 [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant Wolfram Sang
@ 2023-11-13  0:51 ` Wolfram Sang
  2023-12-12  3:30 ` [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant Wolfram Sang
  1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2023-11-13  0:51 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Conor Dooley, Geert Uytterhoeven, Johan Hovold,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-kernel

The Renesas KingFisher board includes a U-Blox Neo-M8 chip. This chip
has a reset pin which is also wired on the board. Introduce a binding to
support this reset pin.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
index 4835a280b3bf..8e97e475613f 100644
--- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
+++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
@@ -41,6 +41,9 @@ properties:
     description: >
       Backup voltage regulator
 
+  reset-gpios:
+    maxItems: 1
+
 required:
   - compatible
   - vcc-supply
@@ -49,10 +52,12 @@ unevaluatedProperties: false
 
 examples:
   - |
+    #include <dt-bindings/gpio/gpio.h>
     serial {
         gnss {
             compatible = "u-blox,neo-8";
             v-bckp-supply = <&gnss_v_bckp_reg>;
             vcc-supply = <&gnss_vcc_reg>;
+            reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
         };
     };
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant
  2023-11-13  0:51 [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant Wolfram Sang
  2023-11-13  0:51 ` [PATCH v5 2/3] dt-bindings: gnss: u-blox: add "reset-gpios" binding Wolfram Sang
@ 2023-12-12  3:30 ` Wolfram Sang
  2023-12-14 15:53   ` Wolfram Sang
  1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2023-12-12  3:30 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: devicetree, Johan Hovold, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

On Sun, Nov 12, 2023 at 07:51:48PM -0500, Wolfram Sang wrote:
> The Renesas KingFisher board includes a U-Blox Neo-M8 chip with its
> reset pin wired to a GPIO. To support that, we need "reset-gpio" support
> (patches 2+3). But first, simplify regulator handling with a new helper
> (patch 1).
> 
> Changes since v4:
> 
> * don't touch reset during open/close. Only deassert it during probe.
>   [patch 3]

Johan, all good now?

Happy hacking,

   Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant
  2023-12-12  3:30 ` [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant Wolfram Sang
@ 2023-12-14 15:53   ` Wolfram Sang
  2023-12-15  8:34     ` Johan Hovold
  0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2023-12-14 15:53 UTC (permalink / raw)
  To: linux-renesas-soc, devicetree, Johan Hovold, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On Tue, Dec 12, 2023 at 04:30:10AM +0100, Wolfram Sang wrote:
> On Sun, Nov 12, 2023 at 07:51:48PM -0500, Wolfram Sang wrote:
> > The Renesas KingFisher board includes a U-Blox Neo-M8 chip with its
> > reset pin wired to a GPIO. To support that, we need "reset-gpio" support
> > (patches 2+3). But first, simplify regulator handling with a new helper
> > (patch 1).
> > 
> > Changes since v4:
> > 
> > * don't touch reset during open/close. Only deassert it during probe.
> >   [patch 3]
> 
> Johan, all good now?

If there are no further comments, can we have this series in 6.8.?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant
  2023-12-14 15:53   ` Wolfram Sang
@ 2023-12-15  8:34     ` Johan Hovold
  2023-12-15 20:15       ` Wolfram Sang
  0 siblings, 1 reply; 6+ messages in thread
From: Johan Hovold @ 2023-12-15  8:34 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: linux-renesas-soc, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On Thu, Dec 14, 2023 at 04:53:06PM +0100, Wolfram Sang wrote:
> On Tue, Dec 12, 2023 at 04:30:10AM +0100, Wolfram Sang wrote:
> > On Sun, Nov 12, 2023 at 07:51:48PM -0500, Wolfram Sang wrote:
> > > The Renesas KingFisher board includes a U-Blox Neo-M8 chip with its
> > > reset pin wired to a GPIO. To support that, we need "reset-gpio" support
> > > (patches 2+3). But first, simplify regulator handling with a new helper
> > > (patch 1).
> > > 
> > > Changes since v4:
> > > 
> > > * don't touch reset during open/close. Only deassert it during probe.
> > >   [patch 3]
> > 
> > Johan, all good now?
> 
> If there are no further comments, can we have this series in 6.8.?

All good. Now applied for 6.8.

Johan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant
  2023-12-15  8:34     ` Johan Hovold
@ 2023-12-15 20:15       ` Wolfram Sang
  0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2023-12-15 20:15 UTC (permalink / raw)
  To: Johan Hovold; +Cc: linux-renesas-soc, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 49 bytes --]

> All good. Now applied for 6.8.

Thank you! :)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-12-15 20:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-13  0:51 [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant Wolfram Sang
2023-11-13  0:51 ` [PATCH v5 2/3] dt-bindings: gnss: u-blox: add "reset-gpios" binding Wolfram Sang
2023-12-12  3:30 ` [PATCH v5 0/3] gnss: ubx: support the reset pin of the Neo-M8 variant Wolfram Sang
2023-12-14 15:53   ` Wolfram Sang
2023-12-15  8:34     ` Johan Hovold
2023-12-15 20:15       ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).