From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Mark Hasemeyer <markhas@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Raul Rangel <rrangel@chromium.org>,
Frank Rowand <frowand.list@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 3/6] of: irq: add wake capable bit to of_irq_resource()
Date: Wed, 13 Dec 2023 21:44:19 +0200 [thread overview]
Message-ID: <ZXoJkwtk_tVrj1IO@smile.fi.intel.com> (raw)
In-Reply-To: <20231213110009.v1.3.I29b26a7f3b80fac0a618707446a10b6cc974fdaf@changeid>
On Wed, Dec 13, 2023 at 11:00:21AM -0700, Mark Hasemeyer wrote:
> Add wake capability information to the irq resource. Wake capability is
IRQ
> assumed based on conventions provided in the devicetree wakeup-source
> binding documentation. An interrupt is considered wake capable if the
> following are true:
> 1. a wakeup-source property exits in the same device node as the
> interrupt.
> 2. No dedicated irq is defined, or the irq is marked as dedicated by
IRQ
> setting its interrupt-name to "wakeup".
>
> The wakeup-source documentation states that dedicated interrupts can use
> device specific interrupt names and device drivers are still welcome to
> use their own naming schemes. This api is provided as a helper if one is
API
> willing to conform to the above conventions.
>
> The ACPI subsystems already provides similar apis that allow one to
APIs
> query the wake capability of an irq. This brings feature parity to the
> devicetree.
...
> +/**
> + * __of_irq_wake_capable - Determine whether a given irq index is wake capable
IRQ
> + * The irq is considered wake capable if the following are true:
IRQ
> + * 1. wakeup-source property exists
> + * 2. no dedicated wakeirq exists OR provided irq index is a dedicated wakeirq
IRQ
> + * This logic assumes the provided irq index is valid.
IRQ
> + * @dev: pointer to device tree node
> + * @index: zero-based index of the irq
IRQ
> + * Return: True if provided irq index for #dev is wake capable. False otherwise.
IRQ
@dev
> + */
...
> /**
> * of_irq_to_resource - Decode a node's IRQ and return it as a resource
> * @dev: pointer to device tree node
> * @index: zero-based index of the irq
> * @r: pointer to resource structure to return result into.
> + *
> + * Return: Linux IRQ number on success, or 0 on the IRQ mapping failure, or
> + * -EPROBE_DEFER if the IRQ domain is not yet created, or error code in case
> + * of any other failure.
> */
You see, your new text is even inconsistent with the existing one...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-13 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231213110009.v1.1.Ifd0903f1c351e84376d71dbdadbd43931197f5ea@changeid>
2023-12-13 18:00 ` [PATCH v1 2/6] arm: arm64: dts: Enable cros-ec-spi as wake source Mark Hasemeyer
2023-12-13 18:08 ` Krzysztof Kozlowski
2023-12-13 22:11 ` Rob Herring
2023-12-14 21:04 ` Mark Hasemeyer
2023-12-14 22:20 ` Rob Herring
2023-12-14 10:55 ` AngeloGioacchino Del Regno
2023-12-14 11:53 ` Konrad Dybcio
2023-12-13 18:00 ` [PATCH v1 3/6] of: irq: add wake capable bit to of_irq_resource() Mark Hasemeyer
2023-12-13 19:44 ` Andy Shevchenko [this message]
2023-12-13 22:19 ` Rob Herring
2023-12-14 21:05 ` Mark Hasemeyer
2023-12-15 15:30 ` Rob Herring
2023-12-15 20:56 ` Mark Hasemeyer
2023-12-18 10:49 ` Sudeep Holla
2023-12-13 18:00 ` [PATCH v1 4/6] of: irq: Add default implementation for of_irq_to_resource() Mark Hasemeyer
2023-12-13 19:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXoJkwtk_tVrj1IO@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markhas@chromium.org \
--cc=robh+dt@kernel.org \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).