devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Abel Vesa <abel.vesa@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: x1e80100: Add all missing nodes
Date: Thu, 14 Dec 2023 23:37:08 +0200	[thread overview]
Message-ID: <ZXt1hOADgY9iofvC@linaro.org> (raw)
In-Reply-To: <ZXsgYl2h+MnTIz7D@linaro.org>

On 23-12-14 17:33:54, Abel Vesa wrote:
> On 23-12-12 17:21:19, Konrad Dybcio wrote:
> > 
> > 
> > On 12/12/23 11:24, Abel Vesa wrote:
> > > Add all missing nodes which describe entire X1E80100 platform.
> > "all" doesn't really mean all :|
> > 

[...]

> > 
> > > +				clocks = <&gcc GCC_DISP_AHB_CLK>,
> > > +					 <&gcc GCC_DISP_HF_AXI_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_AHB_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_MDP_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> > > +				clock-names = "bus",
> > > +					      "nrt_bus",
> > > +					      "iface",
> > > +					      "lut",
> > > +					      "core",
> > > +					      "vsync";
> > you probably should list the ROT clock here too
> 
> Will look into it.
> 

There is no ROT clock.


  parent reply	other threads:[~2023-12-14 21:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 10:24 [PATCH 0/2] arm64: dts: qcom: Add missing nodes to X1E80100 base dtsi and CRD dts Abel Vesa
2023-12-12 10:24 ` [PATCH 1/2] arm64: dts: qcom: x1e80100: Add all missing nodes Abel Vesa
2023-12-12 16:21   ` Konrad Dybcio
2023-12-14 15:33     ` Abel Vesa
2023-12-14 15:39       ` Krzysztof Kozlowski
2023-12-14 21:37       ` Abel Vesa [this message]
2023-12-12 10:24 ` [PATCH 2/2] arm64: dts: qcom: x1e80100: Add missing nodes for CRD Abel Vesa
2023-12-12 16:22   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZXt1hOADgY9iofvC@linaro.org \
    --to=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).