From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65AB720E0; Fri, 15 Dec 2023 01:46:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iUdsPdk3" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-425baafa3c3so1409771cf.0; Thu, 14 Dec 2023 17:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702604791; x=1703209591; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dVWHvDHZz3AvJMZltvNUlCGBm1+VXWDUHdZCGNSWeV4=; b=iUdsPdk3tlUeE+LQ9ha/na4pcCIjp8iDDa4szqTS2AFOJS21llIosh+t2RajE9DvX/ Cwhl3yOTAdzodPgk8rPW7qlZWYUpzysxlLCmI8UBPtvW46oBtjQUORsXcDjkGhZoNVie 9Et5lXCx5LgLhXbThIskD01eNtU3OYuRR8Cr6ZhBnxudkpcyqvS+DtPAc/oSi7NckKXJ 7SRAFJXOOfU8op11BfiFJ6n6qber3JGVq88eAUEpQvdx8c0eF1Xzbruv1BTCg05khT8V SchPUAFxZgpiBUMHkf1197hcVDAoLrSYtvbMxErcvFTr70bgUgc0WYDVFtGW8ONg5KK3 s4EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702604791; x=1703209591; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dVWHvDHZz3AvJMZltvNUlCGBm1+VXWDUHdZCGNSWeV4=; b=ox/SLj4RLV9nZ6knZCSrJngsCfQNkltHMR316H8PgvMXyK9Px+6ilmTdXrf13YPN3Z OP8TbQF8iOe56V6m98ktrZrJD2hFGDdFbdzGvPJTAz1KYnYWn0C1eBWuXf436K7JIX3U 7M+4ZTNCm3BY/ats4NWiQbo/EQzjEgufth6aS+d+pCS8SqoCYL7FA7zwmFEwf/iaYO6f QXX8SEnvgK2IC3DTq5QNpUvHJ8L3tSRdrOCKSDJKBDBIrWfsm57VdriUnkM2e9zxDL8F 4h+Bqf7vNEwuborplp3DN8JqoqCSmw8jUsZE02OinlSDpZJruZiZgSbM5nTFS7ImIfBE ZRMw== X-Gm-Message-State: AOJu0Yxi4EUC3mB178rFeM/D6SW3S8kYARXftxNfIMsNmoo4SaLRc85a QBFxv1/MPz3k+GOuXiscfs3P2Nrn7goJGQ== X-Google-Smtp-Source: AGHT+IGuWqtIDX/gQoLrm4a1Y3PUAD7mxodkVbztEA+x0E/VQdQrJnxhZjSGkZYHCzPIRgoBu2dNKw== X-Received: by 2002:a05:622a:28e:b0:425:a84d:bccc with SMTP id z14-20020a05622a028e00b00425a84dbcccmr14695740qtw.137.1702604791271; Thu, 14 Dec 2023 17:46:31 -0800 (PST) Received: from localhost ([2607:fea8:529e:7800::a768]) by smtp.gmail.com with ESMTPSA id c12-20020ac86e8c000000b004255183b1a4sm6209114qtv.64.2023.12.14.17.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 17:46:30 -0800 (PST) Date: Thu, 14 Dec 2023 20:46:27 -0500 From: Richard Acayan To: Johan Hovold Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] arm64: dts: qcom: sdm670: fix USB DP/DM HS PHY interrupts Message-ID: References: <20231214074319.11023-1-johan+linaro@kernel.org> <20231214074319.11023-2-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214074319.11023-2-johan+linaro@kernel.org> On Thu, Dec 14, 2023 at 08:43:17AM +0100, Johan Hovold wrote: > The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt > controller in order to be able to wake the system up from low-power > states and to be able to detect disconnect events, which requires > triggering on falling edges. > > A recent commit updated the trigger type but failed to change the > interrupt provider as required. This leads to the current Linux driver > failing to probe instead of printing an error during suspend and USB > wakeup not working as intended. > > Fixes: de3b3de30999 ("arm64: dts: qcom: sdm670: fix USB wakeup interrupt types") > Fixes: 07c8ded6e373 ("arm64: dts: qcom: add sdm670 and pixel 3a device trees") > Cc: stable@vger.kernel.org # 6.2 > Cc: Richard Acayan > Signed-off-by: Johan Hovold > --- Tested-by: Richard Acayan On a Pixel 3a, plugging in a USB cable doesn't wake up the device (presumably because there is no wakeup-source property) but this gets USB working again on linux-next.