From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, conor+dt@kernel.org,
krzysztof.kozlowski@linaro.org, robh+dt@kernel.org,
kevin-lu@ti.com, baojun.xu@ti.com, devicetree@vger.kernel.org,
lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@intel.com, soyer@irl.hu, tiwai@suse.de,
peeyush@ti.com, navada@ti.com
Subject: Re: [PATCH v2 3/5] ASoC: tas2781: Add tas2563 into header file for dsp mode
Date: Thu, 21 Dec 2023 17:53:36 +0200 [thread overview]
Message-ID: <ZYRfgCL393O7FEYJ@smile.fi.intel.com> (raw)
In-Reply-To: <20231221101346.429-3-shenghao-ding@ti.com>
On Thu, Dec 21, 2023 at 06:13:43PM +0800, Shenghao Ding wrote:
> Support dsp mode for tas2563.
DSP
...
> +// ALSA SoC Texas Instruments TAS2781/TAS2563 Audio Smart Amplifier
Why not ordered?
...
> +// The TAS2781/TAS2563 driver implements a flexible and configurable
Ditto.
...
> +// TAS2781/TAS2563 chips.
Ditto.
...
> enum audio_device {
> TAS2781 = 0,
> + TAS2563
Missing comma as this is not a terminator.
> };
Ditto.
...
I would expect here
enum audio_device {
TAS2563,
TAS2781,
};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-21 15:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 10:13 [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml Shenghao Ding
2023-12-21 10:13 ` [PATCH v2 2/5] ASoC: tas2562: remove tas2563 into driver Shenghao Ding
2023-12-21 15:52 ` Andy Shevchenko
2023-12-21 10:13 ` [PATCH v2 3/5] ASoC: tas2781: Add tas2563 into header file for dsp mode Shenghao Ding
2023-12-21 15:53 ` Andy Shevchenko [this message]
2023-12-21 10:13 ` [PATCH v2 4/5] ASoC: tas2781: Add tas2563 into driver Shenghao Ding
2023-12-21 15:54 ` Andy Shevchenko
2023-12-21 10:13 ` [PATCH v2 5/5] ASoC: dt-bindings: Add tas2563 into ti,ta2781.yaml to support dsp mode better Shenghao Ding
2023-12-21 17:29 ` Krzysztof Kozlowski
2023-12-21 15:50 ` [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml Andy Shevchenko
2023-12-21 17:31 ` Krzysztof Kozlowski
2023-12-27 7:04 ` [EXTERNAL] " Ding, Shenghao
2023-12-27 10:55 ` Krzysztof Kozlowski
2023-12-23 11:48 ` Ding, Shenghao
2023-12-21 17:31 ` Krzysztof Kozlowski
2023-12-27 7:07 ` [EXTERNAL] " Ding, Shenghao
2023-12-27 10:56 ` Krzysztof Kozlowski
2023-12-27 13:45 ` Ding, Shenghao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYRfgCL393O7FEYJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=peeyush@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).