From: Petre Rodan <petre.rodan@subdimension.ro>
To: Conor Dooley <conor@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: pressure: honeywell,mprls0025pa
Date: Sat, 23 Dec 2023 13:28:33 +0200 [thread overview]
Message-ID: <ZYbEYagM8qBf_cGB@sunspire> (raw)
In-Reply-To: <20231222-thread-secret-d8b49c896249@spud>
[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]
hello Conor,
On Fri, Dec 22, 2023 at 03:27:36PM +0000, Conor Dooley wrote:
> > > - (honeywell,pmin-pascal && honeywell,pmax-pascal) || honeywell,pressure-triplet
> > Yes, it would end up something like that. There are exclusive or examples in tree.
> > oneOf:
> > - required:
> > - honeywell,pmin-pascal
> > - honeywell,pmax-pascal
> > - required:
> > - honeywell,pressure-triplet
> >
> > but you will want to try all the cases to make sure that works (my ability to
> > figure these ones out is tricky).
> >
> > + you ideally want to exclude them all being set which is fiddlier.
> >
> > Some similar examples but they are based on a value in the property. I'm not
> > sure how you check for it just being defined.
> >
> > Something along lines of.
> >
> > allOf:
> > - if:
> > properties:
> > honeywell,pressure-triplet
> > then:
> > properties:
> > honeywell,pmin-pascal: false
> > honeywell,pmax-pascal: false
> >
> > Might work? I always end up trawling the kernel to find a similar example for cases but
> > can't find anything closer right now.
>
> I hate to admit it, but I'm not great at expressing these in the minimum
> forms either, but I think you're missing a "required" from here, in place
> of the "properties":
> allOf:
> - if:
> required:
> - honeywell,pressure-triplet
> then:
> properties:
> honeywell,pmin-pascal: false
> honeywell,pmax-pascal: false
thank you both for the above ruleset, it works like magic.
I spent hours trying to figure out the proper syntax but never got it right.
Merry Christmas!
peter
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-12-23 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231219130230.32584-1-petre.rodan@subdimension.ro>
2023-12-19 13:02 ` [PATCH 1/2] dt-bindings: iio: pressure: honeywell,mprls0025pa Petre Rodan
2023-12-20 15:16 ` Jonathan Cameron
2023-12-20 17:25 ` Petre Rodan
2023-12-21 11:04 ` Jonathan Cameron
2023-12-22 15:27 ` Conor Dooley
2023-12-23 11:28 ` Petre Rodan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYbEYagM8qBf_cGB@sunspire \
--to=petre.rodan@subdimension.ro \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).