From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"William Zhang" <william.zhang@broadcom.com>,
"Anand Gore" <anand.gore@broadcom.com>,
"Kursad Oney" <kursad.oney@broadcom.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Fernández Rojas" <noltari@gmail.com>,
"Sven Schwermer" <sven.schwermer@disruptive-technologies.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [net-next PATCH v6 5/5] net: phy: at803x: add LED support for qca808x
Date: Wed, 3 Jan 2024 16:59:50 +0000 [thread overview]
Message-ID: <ZZWShvM4Fcs3Oogk@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240102183835.5332-6-ansuelsmth@gmail.com>
On Tue, Jan 02, 2024 at 07:38:34PM +0100, Christian Marangi wrote:
> + if (active_low) {
> + ret = phy_clear_bits_mmd(phydev, MDIO_MMD_AN,
> + QCA808X_MMD7_LED_POLARITY_CTRL,
> + QCA808X_LED_ACTIVE_HIGH);
> + } else {
> + ret = phy_set_bits_mmd(phydev, MDIO_MMD_AN,
> + QCA808X_MMD7_LED_POLARITY_CTRL,
> + QCA808X_LED_ACTIVE_HIGH);
> + }
Maybe:
return phy_modify_mmd(phydev, MDIO_MMD_AN,
QCA808X_MMD7_LED_POLARITY_CTRL,
active_low ? 0 : QCA808X_LED_ACTIVE_HIGH);
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2024-01-03 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 18:38 [net-next PATCH v6 0/5] net: phy: generic polarity + LED support for qca808x Christian Marangi
2024-01-02 18:38 ` [net-next PATCH v6 1/5] dt-bindings: net: phy: Make LED active-low property common Christian Marangi
2024-01-02 18:38 ` [net-next PATCH v6 2/5] dt-bindings: net: phy: Document LED inactive high impedance mode Christian Marangi
2024-01-02 18:38 ` [net-next PATCH v6 3/5] net: phy: add support for PHY LEDs polarity modes Christian Marangi
2024-01-02 18:38 ` [net-next PATCH v6 4/5] dt-bindings: net: Document QCA808x PHYs Christian Marangi
2024-01-02 18:38 ` [net-next PATCH v6 5/5] net: phy: at803x: add LED support for qca808x Christian Marangi
2024-01-03 16:59 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZWShvM4Fcs3Oogk@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=anand.gore@broadcom.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kursad.oney@broadcom.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=sven.schwermer@disruptive-technologies.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).