From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67DEC1FBE for ; Fri, 5 Jan 2024 01:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nCAmIKAf" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d4c91a9adcso1385605ad.1 for ; Thu, 04 Jan 2024 17:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704418674; x=1705023474; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=ogVvwDK/Dgt8I5gOLf0rKs+C40ZFKTDawpNUDK/TtKw=; b=nCAmIKAf4W5VQ5WZlzMzbTSXDFyspnQCc2HMRw0jftWtGrTrhlWmKz8W9GBGaKSmPO y9YRaJXB3dTzzNpqtYuLTxB0GLPU6lkfE1TarecJfmbQY3uSOVItO2SKRXnhFMt+CVfI M+FGV4Sub4v4RIWQOIVw7Xdie1B8AJvIqtRceDqrh+WONlqW9ooI+aWGmekLMyCtXMKO 2aOOm/tvWvdEwAT5X36CWn35XnMx61Tea9ZwJQ/+F6aXSho4kuRrqHwiO2lKoS8ftExJ mym+X41fy4QnJUPK1PDnzn2HdQQLJckM+6rC6EPyJ5Sh3y26C3zeTPju/gkiRWyOp6d/ ub8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704418674; x=1705023474; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ogVvwDK/Dgt8I5gOLf0rKs+C40ZFKTDawpNUDK/TtKw=; b=I8l9lKq8ypFTBRKDVOvP1ZKeQgrfrWbZoXOhk0GML+kWy8Qc5woxLh3Js2+9B36OyA JZGFMXZbCFaWrfEuafXKfBR4My/nSIC5ojpqgaEw8fp54OUkktue4/i3/lDeHfQbhrH2 0f7AfGs1wyFQr7ZaKwFagQ7VuUmyl7EZZJdwPWRJrQH3lQ5iMWXYTXq4inVfIOl7bejR p4C5k3ewcXx9kzDlzJ64BxHzTiFa8CJtpoJYx1nSGwVB7NJxmmy4ZwO9qLff4F4bWNSc HKnN9zcA5Y9belPEJ/l8u8rctK/ZGIxmxuTciKyhzLCmskLLVm+j7sZtSUY/XSNe9G/h HZTw== X-Gm-Message-State: AOJu0YySkyzDisl1NYFsbOIjG1T0KYFEaG7vRHHn7NbcmlQAhxdDdotK ghAIFTxFvnSHdbRzmm2DwlVowDlQK1ygbw== X-Google-Smtp-Source: AGHT+IHDVbvAWgoJlpyO71KsCze60J3X7wdM90MBV1iT410hUQh1gPAxB7pvYhlLdwetE0WMN8W3og== X-Received: by 2002:a05:6a21:3384:b0:196:1899:d756 with SMTP id yy4-20020a056a21338400b001961899d756mr3166699pzb.2.1704418673477; Thu, 04 Jan 2024 17:37:53 -0800 (PST) Received: from octopus ([2400:4050:c3e1:100:224b:9c3f:543b:97cb]) by smtp.gmail.com with ESMTPSA id i186-20020a62c1c3000000b006d9a1812e35sm306500pfg.119.2024.01.04.17.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 17:37:53 -0800 (PST) Date: Fri, 5 Jan 2024 10:37:46 +0900 From: AKASHI Takahiro To: "Peng Fan (OSS)" Cc: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksii Moisieiev , Linus Walleij , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan Subject: Re: [PATCH v2 0/6] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-ID: Mail-Followup-To: AKASHI Takahiro , "Peng Fan (OSS)" , Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksii Moisieiev , Linus Walleij , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan References: <20240104-pinctrl-scmi-v2-0-a9bd86ab5a84@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104-pinctrl-scmi-v2-0-a9bd86ab5a84@nxp.com> On Thu, Jan 04, 2024 at 06:48:44PM +0800, Peng Fan (OSS) wrote: > This patchset is a rework from Oleksii's RFC v5 patchset > https://lore.kernel.org/all/cover.1698353854.git.oleksii_moisieiev@epam.com/ > > This patchset introduces some changes based on RFC v5: > - introduce helper get_max_msg_size > - support compatible string > - iterate the id_table > - Support multiple configs in one command > - Added i.MX support > - Patch 5 firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support > is almost same as RFCv5 expect multiple configs support. > - Patch 4 the dt-bindings includes compatible string to support i.MX > - Rebased on 2023-12-15 linux-next/master For the record, the translation of pin config types, pinctrl_scmi_map_pinconf_type(), is finally implemented in patch 4. Thanks, -Takahiro Akashi > If any comments from RFC v5 are missed, I am sorry in advance. > > This PINCTRL Protocol is following Version 3.2 SCMI Spec Beta release. > > On ARM-based systems, a separate Cortex-M based System Control Processor > (SCP) provides control on pins, as well as with power, clocks, reset > controllers. So implement the driver to support such cases. > > The i.MX95 Example as below: > > Configuration: > The scmi-pinctrl driver can be configured using DT bindings. > For example: > / { > sram0: sram@445b1000 { > compatible = "mmio-sram"; > reg = <0x0 0x445b1000 0x0 0x400>; > > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x0 0x0 0x445b1000 0x400>; > > scmi_buf0: scmi-sram-section@0 { > compatible = "arm,scmi-shmem"; > reg = <0x0 0x80>; > }; > > scmi_buf1: scmi-sram-section@80 { > compatible = "arm,scmi-shmem"; > reg = <0x80 0x80>; > }; > }; > > firmware { > scmi { > compatible = "arm,scmi"; > mboxes = <&mu2 5 0>, <&mu2 3 0>, <&mu2 3 1>; > shmem = <&scmi_buf0>, <&scmi_buf1>; > #address-cells = <1>; > #size-cells = <0>; > > scmi_iomuxc: protocol@19 { > compatible = "fsl,imx95-scmi-pinctrl"; > reg = <0x19>; > }; > }; > }; > }; > > &scmi_iomuxc { > pinctrl_tpm3: tpm3grp { > fsl,pins = < > IMX95_PAD_GPIO_IO12__TPM3_CH2 0x51e > >; > }; > }; > > This patchset has been tested on i.MX95-19x19-EVK board. > > Signed-off-by: Peng Fan > --- > Changes in v2: > Added comments, and added R-b for Patch 1 > Moved the compatile string and i.MX patch to the end, marked NOT APPLY > Patchset based on lore.kernel.org/all/20231221151129.325749-1-cristian.marussi@arm.com/ > Addressed the binding doc issue, dropped i.MX content. > For the firmware pinctrl scmi driver, addressed the comments from Cristian > For the pinctrl scmi driver, addressed comments from Cristian > > For the i.MX95 OEM stuff, I not have good idea, expect using compatbile > string. Maybe the firmware public an protocol attribute to indicate it is > VENDOR stuff or NXP use a new protocol id, not 0x19. But I think > current pinctrl-scmi.c not able to support OEM config, should we extend > it with some method? Anyway if patch 1-4 is good enough, they could > be picked up first. > > Since I am only able to test the patch on i.MX95 which not support > geneirc pinconf, only OEM configs are tested in my side. > > --- > Oleksii Moisieiev (1): > firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support > > Peng Fan (5): > firmware: arm_scmi: introduce helper get_max_msg_size > dt-bindings: firmware: arm,scmi: support pinctrl protocol > pinctrl: Implementation of the generic scmi-pinctrl driver > [NOT APPLY]firmware: scmi: support compatible string > [NOT APPLY] pinctrl: scmi: implement pinctrl_scmi_imx_dt_node_to_map > > .../devicetree/bindings/firmware/arm,scmi.yaml | 50 ++ > MAINTAINERS | 7 + > drivers/firmware/arm_scmi/Makefile | 1 + > drivers/firmware/arm_scmi/bus.c | 39 +- > drivers/firmware/arm_scmi/common.h | 2 +- > drivers/firmware/arm_scmi/driver.c | 32 +- > drivers/firmware/arm_scmi/pinctrl.c | 930 +++++++++++++++++++++ > drivers/firmware/arm_scmi/protocols.h | 3 + > drivers/pinctrl/Kconfig | 11 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-scmi-imx.c | 117 +++ > drivers/pinctrl/pinctrl-scmi.c | 540 ++++++++++++ > drivers/pinctrl/pinctrl-scmi.h | 12 + > include/linux/scmi_protocol.h | 75 ++ > 14 files changed, 1806 insertions(+), 14 deletions(-) > --- > base-commit: 8f266a167d1f0ca34668f05cd8c01bd245c8698b > change-id: 20231215-pinctrl-scmi-4c5b0374f4c6 > > Best regards, > -- > Peng Fan >