From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yu-Hsian Yang <j2anfernee@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, javier.carrasco.cruz@gmail.com,
gstols@baylibre.com, tgamblin@baylibre.com,
alisadariana@gmail.com, antoniu.miclaus@analog.com,
eblanc@baylibre.com, jstephan@baylibre.com,
matteomartelli3@gmail.com,
angelogioacchino.delregno@collabora.com,
herve.codina@bootlin.com, marcelo.schmitt@analog.com,
chanh@os.amperecomputing.com, KWLIU@nuvoton.com,
yhyang2@nuvoton.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] iio: adc: add support for Nuvoton NCT7201
Date: Tue, 15 Apr 2025 11:26:22 +0300 [thread overview]
Message-ID: <Z_4YLq_uR_6uroNd@smile.fi.intel.com> (raw)
In-Reply-To: <CA+4VgcKG2EEsicysds0zu7y1xDhg88m3heGUBaQZ7-MVWanCaw@mail.gmail.com>
On Mon, Apr 14, 2025 at 09:40:35PM +0800, Yu-Hsian Yang wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> 於 2025年4月10日 週四 上午12:19寫道：
> > On Wed, Apr 09, 2025 at 09:23:51AM +0800, Eason Yang wrote:
...
> > Here and elsewhere why ' < 0' is used? Do you expect positive return values
> > from those?
>
> In regmap_read function, A value of zero will be returned on success,
> a negative errno will be returned in error cases.
> We don't have a positive return case.
So, can we remove ' < 0' parts where they are not required, please?
...
> > > + chip->client = client;
> >
> > How exactly is _client_ used elsewhere? Shouldn't it be just a struct device
> > pointer?
>
> Yes, it is just a struct device pointer.
> In nct7201_init_chip(chip), we would use the chip->client->dev as
> dev_err_probe() parameter
Just save there struct device *dev and use chip->dev instead.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-04-15 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 1:23 [PATCH v5 0/2] iio: adc: add Nuvoton NCT7201 ADC driver Eason Yang
2025-04-09 1:23 ` [PATCH v5 1/2] dt-bindings: iio: adc: add NCT7201 ADCs Eason Yang
2025-04-09 5:55 ` Krzysztof Kozlowski
2025-04-09 1:23 ` [PATCH v5 2/2] iio: adc: add support for Nuvoton NCT7201 Eason Yang
2025-04-09 16:19 ` Andy Shevchenko
2025-04-14 13:40 ` Yu-Hsian Yang
2025-04-15 8:26 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_4YLq_uR_6uroNd@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=KWLIU@nuvoton.com \
--cc=alisadariana@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=antoniu.miclaus@analog.com \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=eblanc@baylibre.com \
--cc=gstols@baylibre.com \
--cc=herve.codina@bootlin.com \
--cc=j2anfernee@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=jstephan@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=matteomartelli3@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=tgamblin@baylibre.com \
--cc=yhyang2@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).