[PATCH 0/2] Onboard USB device support for RTL8188 2.4GHz USB WiFi module

[PATCH 0/2] Onboard USB device support for RTL8188 2.4GHz USB WiFi module

[J. Neuschäfer via B4 Relay]

This patchset adds rtl8188 (usbbda,179) to the onboard_usb_dev driver.
It is found in a set-top box called "Fernsehfee 3.0".

As a side note, this device is currently marked untested in the RTL8XXXU
driver. In my experience it works (tested with a WPA2 home network).

Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
---
J. Neuschäfer (2):
      dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi
      usb: misc: onboard_dev: Add Realtek RTL8188 WiFi (0bda:0179)

 .../bindings/net/wireless/realtek,rtl8188.yaml     | 51 ++++++++++++++++++++++
 drivers/usb/misc/onboard_usb_dev.c                 |  1 +
 drivers/usb/misc/onboard_usb_dev.h                 |  8 ++++
 3 files changed, 60 insertions(+)
---
base-commit: 38fec10eb60d687e30c8c6b5420d86e8149f7557
change-id: 20250403-rtl-onboard-f38354f0b14b

Best regards,
-- 
J. Neuschäfer <j.ne@posteo.net>

[PATCH 1/2] dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi

[J. Neuschäfer via B4 Relay]

From: "J. Neuschäfer" <j.ne@posteo.net>

This is an on-board USB device that requires a 3.3V supply.

Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
---
 .../bindings/net/wireless/realtek,rtl8188.yaml     | 51 ++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188.yaml b/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..b637c71e3c4d81b47d338394b2e0a7772035c2c7
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/realtek,rtl8188.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek RTL8188 USB WiFi
+
+maintainers:
+  - J. Neuschäfer <j.neuschaefer@gmx.net>
+
+description:
+  The Realtek RTL8188 is a USB-connected 2.4 GHz WiFi module.
+  TODO- website or soemthing
+
+allOf:
+  - $ref: /schemas/usb/usb-device.yaml#
+
+properties:
+  compatible:
+    const: usbbda,179
+
+  reg: true
+
+  vdd-supply:
+    description:
+      Regulator for the 3V3 supply.
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        wifi: wifi@1 {
+            compatible = "usbbda,179";
+            reg = <1>;
+            vdd-supply = <&vcc3v3>;
+        };
+    };
+
+...

-- 
2.48.0.rc1.219.gb6b6757d772

[PATCH 2/2] usb: misc: onboard_dev: Add Realtek RTL8188 WiFi (0bda:0179)

[J. Neuschäfer via B4 Relay]

From: "J. Neuschäfer" <j.ne@posteo.net>

Realtek RTL8188EU 2.4 GHz WiFi modules are found soldered into some
embedded devices, such as the Fernsehfee 3.0 set-top box.

It requires a 3.3V power supply.

Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
---

checkpatch.pl flags the "usbbda" prefix as undocumented because it isn't
in vendor-prefixes.yaml. It is, however, an established pattern:

$ git grep -E 'usb[0-9a-f]{1,4},[0-9a-f]{1,4}' | wc -l
213
---
 drivers/usb/misc/onboard_usb_dev.c | 1 +
 drivers/usb/misc/onboard_usb_dev.h | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c
index 75ac3c6aa92d0d925bb9488d1e6295548446bf98..2f9e8f8108d8c36403b02f3e66db55757d4808ef 100644
--- a/drivers/usb/misc/onboard_usb_dev.c
+++ b/drivers/usb/misc/onboard_usb_dev.c
@@ -584,6 +584,7 @@ static const struct usb_device_id onboard_dev_id_table[] = {
 	{ USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 HUB */
 	{ USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2 HUB */
 	{ USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1 HUB */
+	{ USB_DEVICE(VENDOR_ID_REALTEK, 0x0179) }, /* RTL8188ETV 2.4GHz WiFi */
 	{ USB_DEVICE(VENDOR_ID_TI, 0x8025) }, /* TI USB8020B 3.0 HUB */
 	{ USB_DEVICE(VENDOR_ID_TI, 0x8027) }, /* TI USB8020B 2.0 HUB */
 	{ USB_DEVICE(VENDOR_ID_TI, 0x8140) }, /* TI USB8041 3.0 HUB */
diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h
index 317b3eb99c0255269bb0dbf27b9aa29ef1bc15bd..bee255306d21e1c95d52aaf6aea97518321ea285 100644
--- a/drivers/usb/misc/onboard_usb_dev.h
+++ b/drivers/usb/misc/onboard_usb_dev.h
@@ -38,6 +38,13 @@ static const struct onboard_dev_pdata realtek_rts5411_data = {
 	.is_hub = true,
 };
 
+static const struct onboard_dev_pdata realtek_rtl8188_data = {
+	.reset_us = 0,
+	.num_supplies = 1,
+	.supply_names = { "vdd" },
+	.is_hub = false,
+};
+
 static const struct onboard_dev_pdata ti_tusb8020b_data = {
 	.reset_us = 3000,
 	.num_supplies = 1,
@@ -111,6 +118,7 @@ static const struct of_device_id onboard_dev_match[] = {
 	{ .compatible = "usb5e3,610", .data = &genesys_gl852g_data, },
 	{ .compatible = "usb5e3,620", .data = &genesys_gl852g_data, },
 	{ .compatible = "usb5e3,626", .data = &genesys_gl852g_data, },
+	{ .compatible = "usbbda,179", .data = &realtek_rtl8188_data, },
 	{ .compatible = "usbbda,411", .data = &realtek_rts5411_data, },
 	{ .compatible = "usbbda,5411", .data = &realtek_rts5411_data, },
 	{ .compatible = "usbbda,414", .data = &realtek_rts5411_data, },

-- 
2.48.0.rc1.219.gb6b6757d772

Re: [PATCH 1/2] dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi

[J. Neuschäfer]

On Thu, Apr 03, 2025 at 04:07:48PM +0200, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer" <j.ne@posteo.net>
> 
> This is an on-board USB device that requires a 3.3V supply.
> 
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> ---
[...]
> +maintainers:
> +  - J. Neuschäfer <j.neuschaefer@gmx.net>

Sorry, typoed that. I wanted to use my current email address instead of
this old one. Will fix in v2.

Re: [PATCH 1/2] dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi

[Martin Blumenstingl]

On Thu, Apr 3, 2025 at 4:07 PM J. Neuschäfer via B4 Relay
<devnull+j.ne.posteo.net@kernel.org> wrote:
[...]
> +description:
> +  The Realtek RTL8188 is a USB-connected 2.4 GHz WiFi module.
> +  TODO- website or soemthing
When you re-send this patch (to update the email address) please
delete the TODO (a website is not strictly necessary)

Re: [PATCH 0/2] Onboard USB device support for RTL8188 2.4GHz USB WiFi module

[Bitterblue Smith]

On 03/04/2025 17:07, J. Neuschäfer via B4 Relay wrote:
> This patchset adds rtl8188 (usbbda,179) to the onboard_usb_dev driver.

RTL8188 could mean at least five different chips (C, E, F, G).
Should you use a more specific name like RTL8188EU?

> It is found in a set-top box called "Fernsehfee 3.0".
> 
> As a side note, this device is currently marked untested in the RTL8XXXU
> driver. In my experience it works (tested with a WPA2 home network).
> 
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> ---
> J. Neuschäfer (2):
>       dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi
>       usb: misc: onboard_dev: Add Realtek RTL8188 WiFi (0bda:0179)
> 
>  .../bindings/net/wireless/realtek,rtl8188.yaml     | 51 ++++++++++++++++++++++
>  drivers/usb/misc/onboard_usb_dev.c                 |  1 +
>  drivers/usb/misc/onboard_usb_dev.h                 |  8 ++++
>  3 files changed, 60 insertions(+)
> ---
> base-commit: 38fec10eb60d687e30c8c6b5420d86e8149f7557
> change-id: 20250403-rtl-onboard-f38354f0b14b
> 
> Best regards,

Re: [PATCH 0/2] Onboard USB device support for RTL8188 2.4GHz USB WiFi module

[J. Neuschäfer]

On Mon, Apr 07, 2025 at 01:37:17AM +0300, Bitterblue Smith wrote:
> On 03/04/2025 17:07, J. Neuschäfer via B4 Relay wrote:
> > This patchset adds rtl8188 (usbbda,179) to the onboard_usb_dev driver.
> 
> RTL8188 could mean at least five different chips (C, E, F, G).
> Should you use a more specific name like RTL8188EU?

Yes, that's a good point.

I'm not completely sure which name to pick, though:

 - The chip is marked RTL8188ETV (see photo[1])
 - The RTL8XXXU driver reports it as RTL8188EU


Best regards,
J. Neuschäfer


[1]: https://c3voc.de/gallery/misc/fernsehfee/92QVxQl.jpg.html

Re: [PATCH 0/2] Onboard USB device support for RTL8188 2.4GHz USB WiFi module

[Bitterblue Smith]

On 07/04/2025 13:56, J. Neuschäfer wrote:
> On Mon, Apr 07, 2025 at 01:37:17AM +0300, Bitterblue Smith wrote:
>> On 03/04/2025 17:07, J. Neuschäfer via B4 Relay wrote:
>>> This patchset adds rtl8188 (usbbda,179) to the onboard_usb_dev driver.
>>
>> RTL8188 could mean at least five different chips (C, E, F, G).
>> Should you use a more specific name like RTL8188EU?
> 
> Yes, that's a good point.
> 
> I'm not completely sure which name to pick, though:
> 
>  - The chip is marked RTL8188ETV (see photo[1])
>  - The RTL8XXXU driver reports it as RTL8188EU
> 

Both is good.

> 
> Best regards,
> J. Neuschäfer
> 
> 
> [1]: https://c3voc.de/gallery/misc/fernsehfee/92QVxQl.jpg.html

Re: [PATCH 1/2] dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi

[Rob Herring]

On Thu, Apr 03, 2025 at 04:07:48PM +0200, J. Neuschäfer wrote:
> This is an on-board USB device that requires a 3.3V supply.
> 
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> ---
>  .../bindings/net/wireless/realtek,rtl8188.yaml     | 51 ++++++++++++++++++++++
>  1 file changed, 51 insertions(+)

Looks fine to me other than the issues pointed out.