From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28CC8204C19 for ; Thu, 10 Apr 2025 07:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269068; cv=none; b=DW8nKZIXvPn9/8aOjqUWvzcS884oI/avmtqFz1MV3wGJlB+vEZIssXOHtoPHZ4ciOwYIUpUgwYvYZ5Z82kaeQOKpMeNg+B5x2QcWoLGLcH3I2Uxw4o3iXalUiDZC76OARWOgzUI/2mMGbjnB2MmjfopRG1DwSLCdb9DRT17+Yd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269068; c=relaxed/simple; bh=dvCmIESeU+0C8gMiKn7xzTjU+gOvecKI17trA15juLg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H+55n6xRTOYt2AWH74e5ark6Dn1YlJ+dwluuo96l15iIDvOupSbIwaLWsCNU6sOxcKVGmGdXjxqfLe64iN3BouCV/BKOZt6WjQytLZRAEY9791vvekS4CJ9uBet41usrgbguevDsmA/nG5SZVtND6QT9n2+1uPHteNoaWa5Ne8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tIdOdnh5; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tIdOdnh5" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ac6ed4ab410so78176666b.1 for ; Thu, 10 Apr 2025 00:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744269064; x=1744873864; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=tIdOdnh5oAZhGDM7uWD7RpFi4PXKOpQH6bh/n6RPVExFaUig3IrrpAlmLffcoAUVEU MX014UXDe4T40u/EftWo4s5x7Tfbl6ddorAyUyFoojwWXHNZPXzCUVvJ0BKuLt2Zln56 a9ZaXziLlH5zb79VpOa4J9zfhPBr5SL1YX7Gq/Nb66faCX0wibrTNMCRCeDleyom/yMp MeUi6X82iteHze09A2ldUfnKq+mbSGsEF/6uHwsfp3dBGY+oM0HYZ5aGwa5pOHDHc8Ay CK11lSEjbcHMJzrXDAILKdg1PmRsd1ujsrGNBAswtbvAcRded3p4H/9/qzWLloQS36HJ Kqug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744269064; x=1744873864; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=PoCgKKzGC7dPulPwnyuBlkiOKJChY1OOcaGb6ZPyThDa0k3DmVSq/uYeJxCMLEbPXY 4QU3KGRpEQFSAzWxYUKT6/zgQDEXbZdH4dasJL4FcinbmPFLCDur3W3ZrH+RdIjcSkNF g+iMPWQ9t5xKMyQpFVotoTWd6u6HUH3FDGLorIOk/EhEfF6c42Co6ONvh8bbLCpq13Ja 1u8ZFCfkdEJvrXJublMMgLXRxNexKj3OmcqYPdfhygMlT+YU4WIIHHVJv4vOwZr6BF8W 2t+ZBv+t7WvWUjoPjJBhKDEL5FaGoWBSD8Sq6ATvprr4uyxnH4jHpwpF99S5n/b6hMWz kyaw== X-Forwarded-Encrypted: i=1; AJvYcCXC75Opg4+hBkNcqfVJ2i9Pv2GGS351Z+ufNhQYChyvz54QTDVimCFZTHZCzaR9PXMreUerXDg2pPKB@vger.kernel.org X-Gm-Message-State: AOJu0Yw5MB3EXb+ZRXovhOIcT45YY9cHXIoXRKp7BRW0aWtzUKXaoNk6 wbAmihx5TJyQDpHYSJEPbkrBbIBnCRtVHsYp4KC2zHR8U4GtgDO96iRI8s5zO24= X-Gm-Gg: ASbGncvKG8xrSuy1CO+5jQFFpI2Cot37LuKUYZTj1E6nheNi33oWYlhiaYuUbwMYUqE SyYJsXh88Hf9nJgaKKXmWNLH6w16V/lBE0JlZxYG/1Xv5C/5XOpJgLg9R7C2uYuja6f9cYUkuR3 Hls5toFz6Af3SWMcJaWgnUBeGo8QlY0RqzT2zz/QriqsuGsOGtYLWXig2e3bLP01D0deCeKumiR eQ2maaylAXal2c0yy/6IwK28Q4iz68VQ66f8m0DNytJUoDrI3tFsN8P3naZ69SZmoz7g+biunRC C0b3Fs6Z1etfa+eY1SUWGtbBpNP5+VzpCKMPsxs07yzblZ+BxaQ= X-Google-Smtp-Source: AGHT+IETfspJRi9jQhAHy7G+NAIq/HN8GQhfewV/oWn/J+Tx4X7F7gfIyNI7Jkc9sjEejt3cHqWuJA== X-Received: by 2002:a17:907:da0:b0:aca:a1d7:a830 with SMTP id a640c23a62f3a-acabd185e69mr120878666b.13.1744269064280; Thu, 10 Apr 2025 00:11:04 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:ef30:ae8a:4fb8:9c71:6be]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1cb3fcdsm219989266b.107.2025.04.10.00.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 00:11:03 -0700 (PDT) Date: Thu, 10 Apr 2025 09:10:57 +0200 From: Stephan Gerhold To: Konrad Dybcio Cc: Ulf Hansson , "Rob Herring (Arm)" , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Rafael J. Wysocki" , Viresh Kumar , Matthias Brugger , AngeloGioacchino Del Regno , Vincenzo Frascino , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Bjorn Andersson , Konrad Dybcio , Thomas Bogendoerfer , Viresh Kumar , Nishanth Menon , Stephen Boyd , zhouyanjie@wanyeetech.com, Conor Dooley , Nicolas Ferre , Claudiu Beznea , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Heiko Stuebner , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Manivannan Sadhasivam Subject: Re: [PATCH 09/19] arm: dts: qcom: sdx55/sdx65: Fix CPU power-domain-names Message-ID: References: <20250403-dt-cpu-schema-v1-0-076be7171a85@kernel.org> <20250403-dt-cpu-schema-v1-9-076be7171a85@kernel.org> <03011a33-174b-4027-bdd2-043aa685380b@oss.qualcomm.com> <66f8d957-f7a5-4aec-b8e7-5bcc7ff7f569@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66f8d957-f7a5-4aec-b8e7-5bcc7ff7f569@oss.qualcomm.com> On Wed, Apr 09, 2025 at 08:35:29PM +0200, Konrad Dybcio wrote: > On 4/7/25 6:27 PM, Ulf Hansson wrote: > > On Fri, 4 Apr 2025 at 22:41, Konrad Dybcio > > wrote: > >> > >> On 4/4/25 4:59 AM, Rob Herring (Arm) wrote: > >>> "rpmhpd" is not documented nor used anywhere. As the enable-method is > >>> "psci" use "psci" for the power-domain name. > >>> > >>> Signed-off-by: Rob Herring (Arm) > >>> --- > >> > >> "psci" is what we want here, but these platforms require some more > >> massaging.. > > > > So this isn't for CPU performance scaling? > > Nope! > Huh, this is definitely "perf" (= cpufreq) and not "psci" (= cpuidle). If you run blame on this line you get to: commit 0ec7bde7b590f8efa5823df3b52b32dd373060ff Author: Manivannan Sadhasivam Date: Thu Apr 8 22:34:45 2021 +0530 ARM: dts: qcom: sdx55: Add CPUFreq support Add CPUFreq support to SDX55 platform using the cpufreq-dt driver. There is no dedicated hardware block available on this platform to carry on the CPUFreq duties. Hence, it is accomplished using the CPU clock and regulators tied together by the operating points table. https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0ec7bde7b590f8efa5823df3b52b32dd373060ff The OPP table looks like it's supposed to set SDX55_CX performance states according to the chosen CPU frequency. MSM8909 has a similar setup where the CPU is supplied directly by VDDCX and we describe that with "perf" too [1]. What I don't understand is why the name "rpmhpd" does not appear in any driver. The MSM8909 setup goes via qcom-cpufreq-nvmem, where "perf" is directly assigned for cpufreq scaling. I can only think of two possible reasons: - The power domain is implicitly attached to the OPP table(?), because there is just a single power domain defined on the CPU, or - This was never working correctly. For both cases, I think it would be best to change the power domain name to "perf" like Uffe suggested. Thanks, Stephan [1]: https://lore.kernel.org/linux-pm/20231018-msm8909-cpufreq-v2-0-0962df95f654@kernkonzept.com/