From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-renesas-soc@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: rtc: rzn1: add optional second clock
Date: Thu, 10 Apr 2025 22:23:42 +0200 [thread overview]
Message-ID: <Z_gozhmIeQiPScKK@shikoro> (raw)
In-Reply-To: <CAMuHMdXU7wYfzNmvBO4ibUPGUA6xV_4gQxe4DtuKcr-kqXGB1w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
> > > clock-names:
> > > - const: hclk
> > > + minItems: 1
> > > + items:
> > > + - const: hclk
> > > + - const: xtal
> >
> > Shouldn't the second clock become required? Or do you plan to make
> > that change after all upstream DTS files have been updated?
True, we should make the second clock a requirement from now on.
> Upon second thought: this xtal clock is documented to be the "rtc"
> input to the RZ/N1 system controller[1], so it looks like the original
> idea was to obtain it through the system controller. Unfortunately
> the clock driver[2] does not use the rtc input clock, nor provides it
> to consumers.
So, it would basically be a pass-through? I don't see any register in
SYSCTRL handling the external RTC clock.
> So either we fix that, or we go with your solution...
If it is a pass-through, I wonder what it would gain us, but I can do
that if there are reasons for it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-04-10 20:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 11:03 [PATCH 0/3] rtc: rzn1: support XTAL clk and SCMP method Wolfram Sang
2025-03-19 11:03 ` [PATCH 1/3] dt-bindings: rtc: rzn1: add optional second clock Wolfram Sang
2025-04-10 15:08 ` Geert Uytterhoeven
2025-04-10 15:29 ` Geert Uytterhoeven
2025-04-10 20:23 ` Wolfram Sang [this message]
2025-04-11 6:20 ` Geert Uytterhoeven
2025-04-11 6:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_gozhmIeQiPScKK@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox