Re: [PATCH v2 1/3] dt-bindings: accel: add device tree for AMD PKI accelerator

Krzysztof Kozlowski
2025-04-10T07:29:30Z

On Wed, Apr 09, 2025 at 11:00:31PM GMT, Nipun Gupta wrote:
> Add binding documentation for AMD PKI accelerator supported for AMD
> versal-net SoC.
>

A nit, subject: drop second/last, redundant "device tree for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

You already got this comment...

> AMD PKI accelerator is a device on AMD versa-net SoC to execute public key
> asymmetric crypto operations like ECDSA, ECDH, RSA etc. with high performance.
> The driver provides accel interface to applications for configuring the device
> and performing the required operations. AMD PKI device comprises of multiple
> Barco Silex ba414 PKI engines bundled together, and providing a queue based
> interface to interact with the device.

...

>
> .../bindings/accel/amd,versal-net-pki.yaml | 58 +++++++++++++++++++
> MAINTAINERS | 8 +++
> 2 files changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/accel/amd,versal-net-pki.yaml

That's a crypto device, so goes to 'crypto' directory.

>
> diff --git a/Documentation/devicetree/bindings/accel/amd,versal-net-pki.yaml b/Documentation/devicetree/bindings/accel/amd,versal-net-pki.yaml
> new file mode 100644
> index 000000000000..2dca7458f845
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/accel/amd,versal-net-pki.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/accel/amd,versal-net-pki.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMD PKI accelerator device
> +
> +maintainers:
> + - Nipun Gupta <nipun.gupta@amd.com>
> + - Praveen Jain <praveen.jain@amd.com>
> +
> +description: |
> + AMD PKI accelerator handles the public key asymmetric crypto operations.
> + The driver provides accel interface to the application for configuring the
> + device and performing the required operations. AMD PKI device comprises of
> + multiple Barco Silex ba414 PKI engines bundled together, and providing a
> + queue based interface to interact with these devices on AMD versal-net SoC.
> +
> + Link to ba414 datasheet:
> + https://datasheet.datasheetarchive.com/originals/crawler/barco-silex.com/34b540b9dc5db40c5bc01999401cf1e4.pdf
> +
> +properties:
> + compatible:
> + const: amd,versal-net-pki
> +
> + reg:
> + description: AMD PKI register space

Drop description, obvious.

> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +

And the resets? I understand from previous email that there is a reset controller.

> + iommus: true
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - iommus
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + bus {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + amdpk@20400000000 {

crypto@

> + compatible = "amd,versal-net-pki";
> + interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x204 0x00000000 0x0 0x10000>;
> + iommus = <&smmu 0x25b>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 96b827049501..11f8815daa77 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1154,6 +1154,14 @@ F: Documentation/networking/device_drivers/ethernet/amd/pds_core.rst
> F: drivers/net/ethernet/amd/pds_core/
> F: include/linux/pds/
>
> +AMD PKI DRIVER
> +M: Nipun Gupta <nipun.gupta@amd.com>
> +M: Praveen Jain <praveen.jain@amd.com>
> +L: dri-devel@lists.freedesktop.org
> +S: Maintained
> +T: git https://gitlab.freedesktop.org/drm/misc/kernel.git

Are you going to apply patches to this tree?

Best regards,
Krzysztof