Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

Gupta, Nipun
2025-04-11T18:21:13Z

On 11-04-2025 10:47, Herbert Xu wrote:
> On Fri, Apr 11, 2025 at 10:21:03AM +0530, Gupta, Nipun wrote:
>>
>> added crypto maintainers for comments.
>> IMO, as accel framework is designed to support any type of compute
>> accelerators, the PKI crypto accelerator in accel framework is not
>> completely out of place here, as also suggested at:
>> https://lore.kernel.org/all/2025031352-gyration-deceit-5563@gregkh/
>>
>> Having the crypto accelerator as part of accel also enables to extract
>> the most performance from the HW PKI engines, given that the queue
>> assignment is handled per drm device open call.
>
> There is actually a user-space interface for asymmetric crypto
> through the keyring subsystem. Adding the maintainers of those
> in case they wish to comment on your driver.

AFAIU after looking into it, the keyring subsystem is not to perform the
data operations, but for managing keys for these operations. Kindly
correct me if I am wrong here.

Thanks,
Nipun