From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pv50p00im-zteg10011501.me.com (pv50p00im-zteg10011501.me.com [17.58.6.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F30AA1774E for ; Mon, 15 Jan 2024 15:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kyuhyuk.kr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kyuhyuk.kr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kyuhyuk.kr header.i=@kyuhyuk.kr header.b="JQlNQZqM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyuhyuk.kr; s=sig1; t=1705333733; bh=yxNM4ChCxcfO1k8Hlw537DgVXRAXIZRMKWfvKsTXyrE=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=JQlNQZqMl+B2aYMVXWvFwnRZIExG1g/izHCe19R87x7oy0OItSlfdn9Zx9NQnfvzy IfSbbLTnTFwVj81JEvEBrQQWKvd10Szg39wte6sNhsyhc3rzkFyzwDwJBjHoS1JUL6 U05Jtq1tjR11qRPVKms3rl6zeGcfxfSWy8dxymZbzDONWjQiiMxcBsKui70c+dpeL4 ipWuXcpN0h2tB1wNbPgpSmHZyR00+3qUadrrCbuLi3HCk1RKyJtY86SIUQIHv3DhiA 451YJPZcjxMIe3d351mCnlErLO2Th8i8tTK4vAbpzRNoligIbitVEPlXwf2YeskG1v mSg8gpI2yD5Dw== Received: from kyuhyuk.kr (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-zteg10011501.me.com (Postfix) with ESMTPSA id BC2FF4A0176; Mon, 15 Jan 2024 15:48:49 +0000 (UTC) Date: Tue, 16 Jan 2024 00:48:37 +0900 From: KyuHyuk Lee To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chris Morgan , Tianling Shen , Jagan Teki , Ondrej Jirman , Andy Yan , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board bindings Message-ID: References: <20240115145142.6292-1-lee@kyuhyuk.kr> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: xfG1gLpxLCaQEbJ_kmI3LhtxShXho3-8 X-Proofpoint-GUID: xfG1gLpxLCaQEbJ_kmI3LhtxShXho3-8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-15_10,2024-01-15_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=785 mlxscore=0 clxscore=1030 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2401150115 On Mon, Jan 15, 2024 at 03:58:56PM +0100, Krzysztof Kozlowski wrote: > On 15/01/2024 15:51, KyuHyuk Lee wrote: > > The vendor in ODROID-M1 is hardkernel, but it was incorrectly written > > as rockchip. Fixed the vendor prefix correctly. > > > > Signed-off-by: KyuHyuk Lee > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > You need to start testing your patches. Your last M1 fails as well in > multiple places. > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > > The DTS change will break the users, so would be nice to mention this in > its commit msg. > > Best regards, > Krzysztof > Hello, Krzysztof. I am truly sorry for wasting your time due to my mistake. >From now on, i will carefully send PATCH with testing. I'm really sorry. Thank you, KyuHyuk Lee.