From: Jeff LaBundy <jeff@labundy.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: iqs62x: Do not override firmware-name $ref
Date: Mon, 15 Jan 2024 16:32:36 -0600 [thread overview]
Message-ID: <ZaWyhLcS86Xlw0Vt@nixie71> (raw)
In-Reply-To: <20240115182042.1610134-1-krzysztof.kozlowski@linaro.org>
On Mon, Jan 15, 2024 at 07:20:42PM +0100, Krzysztof Kozlowski wrote:
> dtschema package defines firmware-name as string-array, so individual
> bindings should not make it a string but instead just narrow the number
> of expected firmware file names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Jeff LaBundy <jeff@labundy.com>
> ---
> Documentation/devicetree/bindings/mfd/iqs62x.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> index 044cd7542c2b..f438c2374966 100644
> --- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> +++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> @@ -31,7 +31,7 @@ properties:
> maxItems: 1
>
> firmware-name:
> - $ref: /schemas/types.yaml#/definitions/string
> + maxItems: 1
> description:
> Specifies the name of the calibration and configuration file selected by
> the driver. If this property is omitted, the name is chosen based on the
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-01-15 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 18:20 [PATCH] dt-bindings: mfd: iqs62x: Do not override firmware-name $ref Krzysztof Kozlowski
2024-01-15 22:32 ` Jeff LaBundy [this message]
2024-01-16 17:28 ` Conor Dooley
2024-01-18 14:50 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaWyhLcS86Xlw0Vt@nixie71 \
--to=jeff@labundy.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox