Re: [PATCH v3 3/3] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhhxg1

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

> On Wed, Jan 31, 2024 at 10:11:31AM +0100, Lorenzo Bianconi wrote:
> > Add device bindings for asm330lhhxg1 IMU sensor.
> > The asm330lhhx supports a subset of the features and functionality
> > provided by the lsm6dsr via identical interfaces and so is a
> > suitable fallback compatible.
> 
> A subset cannot fallback to a superset.
> 
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > index 28b667a9cb76..316601b2da7a 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > @@ -49,6 +49,9 @@ properties:
> >        - items:
> >            - const: st,asm330lhb
> >            - const: st,asm330lhh
> > +      - items:
> > +          - const: st,asm330lhhxg1
> > +          - const: st,lsm6dsr
> 
> Assuming this is correct and the commit msg is wrong, can't this be 
> added to the existing entry?:
> 
> items:
>   - enum:
>       - st,asm330lhhx
>       - st,asm330lhhxg1
>   - const: st,lsm6dsr

ack, I will fix it in v4.

Regards,
Lorenzo

> 
> 
> >  
> >    reg:
> >      maxItems: 1
> > -- 
> > 2.43.0
> > 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]