From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE8A11CBB for ; Fri, 26 Jan 2024 08:18:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706257127; cv=none; b=YKNNOZBuNgPxItpnvbSjzgFVCIGyhnuwmMhRqSO5ocfhmpPfiT1WBUfKGmf6Cxpb9qiGqjewcRjelg5uo35P3IC7STnINdXODs0FfgTdnnTmtyJzi77jVWz1sJbPd+LJq+3YVk1MEr66Vjhdvdccgr9Kmpp/j+XvPxnwNTrPm6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706257127; c=relaxed/simple; bh=1v1p0jrAJR50Kueh7YF9CPLO/I/oXE+euJsb8wrKQ+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a8W//ZMov3IXShrJHXlPI93PxnNtj4Ovcn6Alg/JA4OWhBaBpcW+FXgvfN5JfFwYta4eTrsNrzj8kAn3P0YdDskbK7tdXvB81JL83iF4iWJehIFxMhL0S0Xn755HN5B5PzcSq4Z2gZdy+pAYUi6XxFmBTe0wPjgqObRvbzphSXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=H+JeTIhF; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H+JeTIhF" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a2a17f3217aso17613866b.2 for ; Fri, 26 Jan 2024 00:18:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706257124; x=1706861924; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3eKbQ9dPSaynT5h1DWbytWa8cizVUJhYOPdgPpMBlYw=; b=H+JeTIhFKdgDE97RUL23Y7vt9Hab569XLsLp7NT00I2ZZ74HeOAnxqIgK9P//DwNIG iengf9mXTH1kjZpDsMV97EfQMnViFr+2XiOieFlOKYEm37MRjy3bgOuJf6d+4LmHx+Hw QSR3yZCf3Xzj4LbZmJCYc54l63C/qrRMqqppr+nfT5a+mXSYQR/klx/C6og0iacysYVw q5QYVXfazGNnbgmsK7E8w5pezGWsHdGaJbv6NoMapvfzJNKuR4zWTo+jvraxBOiC9uGr 1ONZj/FMDRb/dREzmF0rpo0ywp/nYHT7XfSsbyiVvGPaFfO1vwCnWO6aPOIZL4eQFXPn de+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706257124; x=1706861924; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3eKbQ9dPSaynT5h1DWbytWa8cizVUJhYOPdgPpMBlYw=; b=HXSP7VVrCagChDdV/uXEL9Lnxv9qmr/kqjTqB2V6ZxvXvUuI6F5mGw8aMJPsvKpgMc E8zu4iT9M/OjlA9UH1zqQHCvTwdmA2npqB8EKHDA7Cw6LXF/CiBiQdjPYywk+bcJ1GOu yaRtfuWOz9VP1pi1M+8XXnXCLp+M9evbU8KnO65CYoL4uxpnu3YJGt+Rt9QP44dbInEU ORuNzMryu5iEVmaouGoCBXAvi6GyvfNFm52KbALusbbSbwDHuWzqbzvc54zROARfTKh7 tnoQrnUXF+Cbbja6jFAei9Ou2EsTADC9yyLK4cJYqY3Q94ibcWVxyFO5fXyzAOgVM/y+ 6nTQ== X-Gm-Message-State: AOJu0YzXTLHcadvIr0BhUz7o8yu1eFgX+BSEmlZoWZv5ytQZ/RLNF7H2 T3gn/kjc9CTH5lph6MQTt9RzWEEwA9tY9HL+Kf4saqrWJLUGQX5LtXWrs7IkBQ8= X-Google-Smtp-Source: AGHT+IGAHjYbYuhhbEn3hJ2jgzKambyOC27Tkan/Yq9Qzl1vlpSHYnZRuSY3GbgR8HYC+EhmgrcwyQ== X-Received: by 2002:a17:907:1751:b0:a30:ec79:25f3 with SMTP id lf17-20020a170907175100b00a30ec7925f3mr893519ejc.42.1706257123688; Fri, 26 Jan 2024 00:18:43 -0800 (PST) Received: from linaro.org ([79.115.23.25]) by smtp.gmail.com with ESMTPSA id ck5-20020a170906c44500b00a31930ffa7esm358242ejb.153.2024.01.26.00.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 00:18:43 -0800 (PST) Date: Fri, 26 Jan 2024 10:18:41 +0200 From: Abel Vesa To: Konrad Dybcio Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sibi Sankar , Rajendra Nayak , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 05/11] arm64: dts: qcom: x1e80100: Add TCSR node Message-ID: References: <20240123-x1e80100-dts-missing-nodes-v4-0-072dc2f5c153@linaro.org> <20240123-x1e80100-dts-missing-nodes-v4-5-072dc2f5c153@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 24-01-23 19:09:37, Konrad Dybcio wrote: > > > On 1/23/24 12:01, Abel Vesa wrote: > > Add the TCSR clock controller and halt register space node. > > > > Signed-off-by: Abel Vesa > > --- > > The former - yes, the latter - ? Hm, so halt register space is at 0x1f60000. That would be in the mutex region. But the mutex region is 0x20000 short, even on SM8650 and SM8550. Need to see why is that, historically. Either way, the tcsr node region still contains the regs needed by the SCM driver to enable download mode. So I will rephrase this accordingly. > > Konrad > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > index be69e71b7f53..2b6c55a486b2 100644 > > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > @@ -2606,6 +2606,14 @@ tcsr_mutex: hwlock@1f40000 { > > #hwlock-cells = <1>; > > }; > > + tcsr: clock-controller@1fc0000 { > > + compatible = "qcom,x1e80100-tcsr", "syscon"; > > + reg = <0 0x01fc0000 0 0x30000>; > > + clocks = <&rpmhcc RPMH_CXO_CLK>; > > + #clock-cells = <1>; > > + #reset-cells = <1>; > > + }; > > + > > gem_noc: interconnect@26400000 { > > compatible = "qcom,x1e80100-gem-noc"; > > reg = <0 0x26400000 0 0x311200>; > >