From: Petre Rodan <petre.rodan@subdimension.ro>
To: marius.cristea@microchip.com
Cc: jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
jdelvare@suse.com, linux@roeck-us.net,
linux-hwmon@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] iio: adc: adding support for PAC193x
Date: Fri, 26 Jan 2024 12:58:43 +0200 [thread overview]
Message-ID: <ZbOQY3cs5emASvzs@sunspire> (raw)
In-Reply-To: <20240122084712.11507-3-marius.cristea@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Hello Marius,
a quick static scan reported the following
On Mon, Jan 22, 2024 at 10:47:12AM +0200, marius.cristea@microchip.com wrote:
> From: Marius Cristea <marius.cristea@microchip.com>
>
> This is the iio driver for Microchip
> PAC193X series of Power Monitor with Accumulator chip family.
[..]
> + mutex_init(&info->lock);
> + ret = devm_add_action_or_reset(&client->dev, pac1934_mutex_destroy,
> + &info->lock);
> +
> + /*
> + * do now any chip specific initialization (e.g. read/write
> + * some registers), enable/disable certain channels, change the sampling
> + * rate to the requested value
> + */
> + ret = pac1934_chip_configure(info);
> + if (ret < 0)
> + return ret;
the previous assignation of ret is never used, so either dead code or you might
have wanted to return early based on it's value.
cheers,
peter
--
petre rodan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-01-26 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 8:47 [PATCH v4 0/2] adding support for Microchip PAC193X Power Monitor marius.cristea
2024-01-22 8:47 ` [PATCH v4 1/2] dt-bindings: iio: adc: adding support for PAC193X marius.cristea
2024-01-22 18:15 ` Conor Dooley
2024-01-22 8:47 ` [PATCH v4 2/2] iio: adc: adding support for PAC193x marius.cristea
2024-01-26 10:58 ` Petre Rodan [this message]
2024-01-27 16:47 ` Jonathan Cameron
2024-01-28 12:06 ` kernel test robot
2024-01-22 14:57 ` [PATCH v4 0/2] adding support for Microchip PAC193X Power Monitor Guenter Roeck
2024-01-22 19:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbOQY3cs5emASvzs@sunspire \
--to=petre.rodan@subdimension.ro \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marius.cristea@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).