From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF14C1EB24 for ; Fri, 26 Jan 2024 17:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706289077; cv=none; b=MfZ4LWoFRuyBJ0mzJdL+CJ5R/w3YAes6Wk9GLF2ChTw6Sxo8M4N3BH5S1F1LQhpkzn/6H8/HhN587Bdv+h1YU0EpfTDMnTjkY6dn2d+7cO8cHojwcntuspl8uiIFwbbM5eC3LptJtbeogYoHzHDONyj2dZX6FZNnGyH2IAE/qD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706289077; c=relaxed/simple; bh=myUzh7h3fVvuZHFheFBptRZjheKUkmepBvqM0dn7hJU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e8y6pKL2y2YVA6jgP8SFLzFEpv/nM10mc40ngCPZ8KYNKq0VSd+aVieB3iehI3AGGf75FLqxPcb8K0w2MaVdvewtJU07zOnjA+nlM0qzRCW7Ho+UgZljAEaBijmBWPOyr1c1KmkMzBGkmz+Kb6cVO7Tl4ui3fDougyZuIAj3UDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bbD+yjti; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bbD+yjti" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d73066880eso5594205ad.3 for ; Fri, 26 Jan 2024 09:11:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706289075; x=1706893875; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Bcmrpd25Eu3WOVR04Y5OIk5yOCebYwVXK+pO0q0F6mw=; b=bbD+yjti1rqpxtZvqDVnLGAv3QKBu9B9hkaSYSTRksTQIJlQ6V1IpZFNvm1Md6MdCo hkVQM5aQT/YSdpdSu2wzboPUdsGpslqWtKkWihw+75IuD3ZlenOx9P/ovriUNWJ2ZrBO wWBWp31wQ2TEhEcZvXF5O0ULNTwe5+uI88l92HoSlXe51GGO7d1Hyp5g4K500dd0Lpmt wh0gYo7rIwTBhmHUU07mYgR9TYblCwHbxznLvCLZAtkiZ8lCLQ9s551mq8dH497mY92q ZbecU3e9Cq3g0JrMFraK3w4F7v5SxHKygWGNYHQAF4VmZ5zmcS5+HohRkvaZ2qTI7Kzq jacQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706289075; x=1706893875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bcmrpd25Eu3WOVR04Y5OIk5yOCebYwVXK+pO0q0F6mw=; b=A4sQVbjp0HFZchNdQbjvTMcgXEuN59D+1y5sr1oE0Rsq/U4TZWNKAMst7EJjIi7wxY fMjgfcSb6somOK0kg65BEaOgShb83NJ9ypfEJwWSHNG0sn9HMY13hRGlNzdSTaEcNRAs qlGH0sg91RIz/xUpbF4frqGL2K8ys76/MzQiJXEuvybzhpF5DQ2pI5/bfTjMSUYasCSs +x36M0LH347qDIEtsPVHFK+rBnuJJu0Ej1ph76sRco4if+LVlv8YRjsH7+JapDbKJeem 6FOUbUYSCmezjT2TsE6P3E7JUrMdan3/j4RF7vXA+txSr34cwFEvat+Wh/uCP2HwoP5/ BaFA== X-Gm-Message-State: AOJu0Yz8QLaXLmOPtgicQaYtliE26BP3SxxC9C3B1qJi+Z5oN5dPgRCv WRQZT6zwX05IBnv2yeMzEql7dv8HGy5s6Q/rXbANyyQEnvrivtCPEFR/opipYx0= X-Google-Smtp-Source: AGHT+IH5z9sKSNksJAUu83TwSp/rNEwRd7Og2IHYScnBP9tAbNauGL8Vlp/pDWgaLQsQX0ukE3j7ww== X-Received: by 2002:a17:902:e995:b0:1d7:35e0:2b5b with SMTP id f21-20020a170902e99500b001d735e02b5bmr52432plb.125.1706289075281; Fri, 26 Jan 2024 09:11:15 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:4ad7:9f92:4f45:da3f]) by smtp.gmail.com with ESMTPSA id v10-20020a170902d08a00b001d72f145ebdsm1175527plv.35.2024.01.26.09.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 09:11:14 -0800 (PST) Date: Fri, 26 Jan 2024 10:11:12 -0700 From: Mathieu Poirier To: Arnaud Pouliquen Cc: Bjorn Andersson , Jens Wiklander , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware Message-ID: References: <20240118100433.3984196-1-arnaud.pouliquen@foss.st.com> <20240118100433.3984196-5-arnaud.pouliquen@foss.st.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118100433.3984196-5-arnaud.pouliquen@foss.st.com> On Thu, Jan 18, 2024 at 11:04:33AM +0100, Arnaud Pouliquen wrote: > The new TEE remoteproc device is used to manage remote firmware in a > secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is > introduced to delegate the loading of the firmware to the trusted > execution context. In such cases, the firmware should be signed and > adhere to the image format defined by the TEE. > > Signed-off-by: Arnaud Pouliquen > --- > V1 to V2 update: > - remove the select "TEE_REMOTEPROC" in STM32_RPROC config as detected by > the kernel test robot: > WARNING: unmet direct dependencies detected for TEE_REMOTEPROC > Depends on [n]: REMOTEPROC [=y] && OPTEE [=n] > Selected by [y]: > - STM32_RPROC [=y] && (ARCH_STM32 || COMPILE_TEST [=y]) && REMOTEPROC [=y] > - Fix initialized trproc variable in stm32_rproc_probe > --- > drivers/remoteproc/stm32_rproc.c | 149 +++++++++++++++++++++++++++++-- > 1 file changed, 144 insertions(+), 5 deletions(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index fcc0001e2657..cf6a21bac945 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > > #include "remoteproc_internal.h" > @@ -49,6 +50,9 @@ > #define M4_STATE_STANDBY 4 > #define M4_STATE_CRASH 5 > > +/* Remote processor unique identifier aligned with the Trusted Execution Environment definitions */ > +#define STM32_MP1_M4_PROC_ID 0 > + > struct stm32_syscon { > struct regmap *map; > u32 reg; > @@ -90,6 +94,8 @@ struct stm32_rproc { > struct stm32_mbox mb[MBOX_NB_MBX]; > struct workqueue_struct *workqueue; > bool hold_boot_smc; > + bool fw_loaded; > + struct tee_rproc *trproc; > void __iomem *rsc_va; > }; > > @@ -257,6 +263,91 @@ static int stm32_rproc_release(struct rproc *rproc) > return err; > } > > +static int stm32_rproc_tee_elf_sanity_check(struct rproc *rproc, > + const struct firmware *fw) > +{ > + struct stm32_rproc *ddata = rproc->priv; > + unsigned int ret = 0; > + > + if (rproc->state == RPROC_DETACHED) > + return 0; > + > + ret = tee_rproc_load_fw(ddata->trproc, fw); > + if (!ret) > + ddata->fw_loaded = true; > + > + return ret; > +} > + > +static int stm32_rproc_tee_elf_load(struct rproc *rproc, > + const struct firmware *fw) > +{ > + struct stm32_rproc *ddata = rproc->priv; > + unsigned int ret; > + > + /* > + * This function can be called by remote proc for recovery > + * without the sanity check. In this case we need to load the firmware > + * else nothing done here as the firmware has been preloaded for the > + * sanity check to be able to parse it for the resource table. > + */ This comment is very confusing - please consider refactoring. > + if (ddata->fw_loaded) > + return 0; > + I'm not sure about keeping a flag to indicate the status of the loaded firmware. It is not done for the non-secure method, I don't see why it would be needed for the secure one. > + ret = tee_rproc_load_fw(ddata->trproc, fw); > + if (ret) > + return ret; > + ddata->fw_loaded = true; > + > + /* Update the resource table parameters. */ > + if (rproc_tee_get_rsc_table(ddata->trproc)) { > + /* No resource table: reset the related fields. */ > + rproc->cached_table = NULL; > + rproc->table_ptr = NULL; > + rproc->table_sz = 0; > + } > + > + return 0; > +} > + > +static struct resource_table * > +stm32_rproc_tee_elf_find_loaded_rsc_table(struct rproc *rproc, > + const struct firmware *fw) > +{ > + struct stm32_rproc *ddata = rproc->priv; > + > + return tee_rproc_get_loaded_rsc_table(ddata->trproc); > +} > + > +static int stm32_rproc_tee_start(struct rproc *rproc) > +{ > + struct stm32_rproc *ddata = rproc->priv; > + > + return tee_rproc_start(ddata->trproc); > +} > + > +static int stm32_rproc_tee_attach(struct rproc *rproc) > +{ > + /* Nothing to do, remote proc already started by the secured context. */ > + return 0; > +} > + > +static int stm32_rproc_tee_stop(struct rproc *rproc) > +{ > + struct stm32_rproc *ddata = rproc->priv; > + int err; > + > + stm32_rproc_request_shutdown(rproc); > + > + err = tee_rproc_stop(ddata->trproc); > + if (err) > + return err; > + > + ddata->fw_loaded = false; > + > + return stm32_rproc_release(rproc); > +} > + > static int stm32_rproc_prepare(struct rproc *rproc) > { > struct device *dev = rproc->dev.parent; > @@ -319,7 +410,14 @@ static int stm32_rproc_prepare(struct rproc *rproc) > > static int stm32_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw) > { > - if (rproc_elf_load_rsc_table(rproc, fw)) > + struct stm32_rproc *ddata = rproc->priv; > + int ret; > + > + if (ddata->trproc) > + ret = rproc_tee_get_rsc_table(ddata->trproc); > + else > + ret = rproc_elf_load_rsc_table(rproc, fw); > + if (ret) > dev_warn(&rproc->dev, "no resource table found for this firmware\n"); > > return 0; > @@ -693,8 +791,22 @@ static const struct rproc_ops st_rproc_ops = { > .get_boot_addr = rproc_elf_get_boot_addr, > }; > > +static const struct rproc_ops st_rproc_tee_ops = { > + .prepare = stm32_rproc_prepare, > + .start = stm32_rproc_tee_start, > + .stop = stm32_rproc_tee_stop, > + .attach = stm32_rproc_tee_attach, > + .kick = stm32_rproc_kick, > + .parse_fw = stm32_rproc_parse_fw, > + .find_loaded_rsc_table = stm32_rproc_tee_elf_find_loaded_rsc_table, > + .get_loaded_rsc_table = stm32_rproc_get_loaded_rsc_table, > + .sanity_check = stm32_rproc_tee_elf_sanity_check, > + .load = stm32_rproc_tee_elf_load, > +}; > + > static const struct of_device_id stm32_rproc_match[] = { > - { .compatible = "st,stm32mp1-m4" }, > + {.compatible = "st,stm32mp1-m4",}, > + {.compatible = "st,stm32mp1-m4-tee",}, > {}, > }; > MODULE_DEVICE_TABLE(of, stm32_rproc_match); > @@ -853,6 +965,7 @@ static int stm32_rproc_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct stm32_rproc *ddata; > struct device_node *np = dev->of_node; > + struct tee_rproc *trproc = NULL; > struct rproc *rproc; > unsigned int state; > int ret; > @@ -861,11 +974,31 @@ static int stm32_rproc_probe(struct platform_device *pdev) > if (ret) > return ret; > > - rproc = rproc_alloc(dev, np->name, &st_rproc_ops, NULL, sizeof(*ddata)); > - if (!rproc) > - return -ENOMEM; > + if (of_device_is_compatible(np, "st,stm32mp1-m4-tee")) { > + trproc = tee_rproc_register(dev, STM32_MP1_M4_PROC_ID); > + if (IS_ERR(trproc)) { > + dev_err_probe(dev, PTR_ERR(trproc), > + "signed firmware not supported by TEE\n"); > + return PTR_ERR(trproc); > + } > + /* > + * Delegate the firmware management to the secure context. > + * The firmware loaded has to be signed. > + */ > + dev_info(dev, "Support of signed firmware only\n"); Not sure what this adds. Please remove. > + } > + rproc = rproc_alloc(dev, np->name, > + trproc ? &st_rproc_tee_ops : &st_rproc_ops, > + NULL, sizeof(*ddata)); > + if (!rproc) { > + ret = -ENOMEM; > + goto free_tee; > + } > > ddata = rproc->priv; > + ddata->trproc = trproc; > + if (trproc) > + trproc->rproc = rproc; > > rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_NONE); > > @@ -916,6 +1049,10 @@ static int stm32_rproc_probe(struct platform_device *pdev) > device_init_wakeup(dev, false); > } > rproc_free(rproc); > +free_tee: > + if (trproc) > + tee_rproc_unregister(trproc); > + > return ret; > } > > @@ -937,6 +1074,8 @@ static void stm32_rproc_remove(struct platform_device *pdev) > device_init_wakeup(dev, false); > } > rproc_free(rproc); > + if (ddata->trproc) > + tee_rproc_unregister(ddata->trproc); > } > > static int stm32_rproc_suspend(struct device *dev) > -- > 2.25.1 >