From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Robin van der Gracht <robin@protonic.nl>,
Paul Burton <paulburton@kernel.org>
Subject: Re: [PATCH v2 10/15] auxdisplay: linedisp: Provide a small buffer in the struct linedisp
Date: Thu, 15 Feb 2024 14:19:32 +0200 [thread overview]
Message-ID: <Zc4BVIwpAqJYPuTH@smile.fi.intel.com> (raw)
In-Reply-To: <Zc4Au5Q_rOAx7_4Y@smile.fi.intel.com>
On Thu, Feb 15, 2024 at 02:17:00PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 15, 2024 at 11:40:44AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
...
> > > + linedisp->buf = buf ? buf : linedisp->curr;
> > > + linedisp->num_chars = buf ? num_chars : min(num_chars, LINEDISP_DEFAULT_BUF_SZ);
> >
> > I think it would be safer to return an error if buf == NULL and
> > num_chars < LINEDISP_DEFAULT_BUF_SZ.
>
> I think you meant >= ?
>
> > Else a careless driver that doesn't check linedisp->num_chars might
> > overflow the buffer.
>
> Okay, check has been added.
Hold on, but I have min() being called, isn't it enough?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-15 12:19 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 17:01 [PATCH v2 00/15] auxdisplay: linedisp: Clean up and add new driver Andy Shevchenko
2024-02-12 17:01 ` [PATCH v2 01/15] auxdisplay: img-ascii-lcd: Make container_of() no-op for struct linedisp Andy Shevchenko
2024-02-15 10:03 ` Geert Uytterhoeven
2024-02-12 17:01 ` [PATCH v2 02/15] auxdisplay: linedisp: Free allocated resources in ->release() Andy Shevchenko
2024-02-15 10:03 ` Geert Uytterhoeven
2024-02-12 17:01 ` [PATCH v2 03/15] auxdisplay: linedisp: Use unique number for id Andy Shevchenko
2024-02-15 10:03 ` Geert Uytterhoeven
2024-02-15 11:28 ` Andy Shevchenko
2024-02-12 17:01 ` [PATCH v2 04/15] auxdisplay: linedisp: Unshadow error codes in ->store() Andy Shevchenko
2024-02-15 10:03 ` Geert Uytterhoeven
2024-02-12 17:01 ` [PATCH v2 05/15] auxdisplay: linedisp: Add missing header(s) Andy Shevchenko
2024-02-15 10:03 ` Geert Uytterhoeven
2024-02-12 17:01 ` [PATCH v2 06/15] auxdisplay: linedisp: Move exported symbols to a namespace Andy Shevchenko
2024-02-15 10:04 ` Geert Uytterhoeven
2024-02-12 17:01 ` [PATCH v2 07/15] auxdisplay: linedisp: Group line display drivers together Andy Shevchenko
2024-02-15 10:05 ` Geert Uytterhoeven
2024-02-15 11:30 ` Andy Shevchenko
2024-02-15 12:35 ` Geert Uytterhoeven
2024-02-15 13:57 ` Andy Shevchenko
2024-02-12 17:01 ` [PATCH v2 08/15] auxdisplay: linedisp: Provide struct linedisp_ops for future extension Andy Shevchenko
2024-02-15 10:13 ` Geert Uytterhoeven
2024-02-15 12:11 ` Andy Shevchenko
2024-02-12 17:01 ` [PATCH v2 09/15] auxdisplay: linedisp: Add support for overriding character mapping Andy Shevchenko
2024-02-15 10:36 ` Geert Uytterhoeven
2024-02-15 12:14 ` Andy Shevchenko
2024-02-12 17:01 ` [PATCH v2 10/15] auxdisplay: linedisp: Provide a small buffer in the struct linedisp Andy Shevchenko
2024-02-15 10:40 ` Geert Uytterhoeven
2024-02-15 12:16 ` Andy Shevchenko
2024-02-15 12:19 ` Andy Shevchenko [this message]
2024-02-15 12:33 ` Geert Uytterhoeven
2024-02-15 13:57 ` Andy Shevchenko
2024-02-12 17:01 ` [PATCH v2 11/15] auxdisplay: ht16k33: Move ht16k33_linedisp_ops down Andy Shevchenko
2024-02-15 8:09 ` Robin van der Gracht
2024-02-15 10:41 ` Geert Uytterhoeven
2024-02-12 17:01 ` [PATCH v2 12/15] auxdisplay: ht16k33: Switch to use line display character mapping Andy Shevchenko
2024-02-15 8:09 ` Robin van der Gracht
2024-02-15 8:16 ` Geert Uytterhoeven
2024-02-15 12:20 ` Andy Shevchenko
2024-02-15 12:31 ` Geert Uytterhoeven
2024-02-15 10:44 ` Geert Uytterhoeven
2024-02-15 10:47 ` Geert Uytterhoeven
2024-02-12 17:01 ` [PATCH v2 13/15] auxdisplay: ht16k33: Use buffer from struct linedisp Andy Shevchenko
2024-02-15 8:09 ` Robin van der Gracht
2024-02-15 10:46 ` Geert Uytterhoeven
2024-02-12 17:01 ` [PATCH v2 14/15] dt-bindings: auxdisplay: Add Maxim MAX6958/6959 Andy Shevchenko
2024-02-12 17:14 ` Andy Shevchenko
2024-02-12 17:16 ` Andy Shevchenko
2024-02-15 8:21 ` Krzysztof Kozlowski
2024-02-15 11:18 ` Andy Shevchenko
2024-02-15 10:57 ` Geert Uytterhoeven
2024-02-15 11:17 ` Andy Shevchenko
2024-02-15 12:26 ` Geert Uytterhoeven
2024-02-12 17:01 ` [PATCH v2 15/15] auxdisplay: Add driver for MAX695x 7-segment LED controllers Andy Shevchenko
2024-02-15 11:01 ` Geert Uytterhoeven
2024-02-14 17:57 ` [PATCH v2 00/15] auxdisplay: linedisp: Clean up and add new driver Andy Shevchenko
2024-02-14 18:45 ` Geert Uytterhoeven
2024-02-14 18:51 ` Andy Shevchenko
2024-02-15 11:05 ` Geert Uytterhoeven
2024-02-15 12:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc4BVIwpAqJYPuTH@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).